diff mbox series

[41/42] mfd: wm8400: use PLATFORM_DEVID_NONE

Message ID 20200921205016.20461-41-krzk@kernel.org
State Superseded
Headers show
Series [01/42] mfd: arizona: use PLATFORM_DEVID_NONE | expand

Commit Message

Krzysztof Kozlowski Sept. 21, 2020, 8:50 p.m. UTC 
Use PLATFORM_DEVID_NONE define instead of "-1" value because:
 - it brings some meaning,
 - it might point attention why auto device ID was not used.

Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
---
 drivers/mfd/wm8400-core.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

Comments

Charles Keepax Sept. 22, 2020, 8:48 a.m. UTC | #1 
On Mon, Sep 21, 2020 at 10:50:15PM +0200, Krzysztof Kozlowski wrote:
> Use PLATFORM_DEVID_NONE define instead of "-1" value because:

>  - it brings some meaning,

>  - it might point attention why auto device ID was not used.

> 

> Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>

> ---


Acked-by: Charles Keepax <ckeepax@opensource.cirrus.com>


Thanks,
Charles
diff mbox series

Patch

diff --git a/drivers/mfd/wm8400-core.c b/drivers/mfd/wm8400-core.c
index 0fe32a05421b..9efca6f3fbb2 100644
--- a/drivers/mfd/wm8400-core.c
+++ b/drivers/mfd/wm8400-core.c
@@ -38,7 +38,8 @@  static int wm8400_register_codec(struct wm8400 *wm8400)
 		.pdata_size = sizeof(*wm8400),
 	};
 
-	return devm_mfd_add_devices(wm8400->dev, -1, &cell, 1, NULL, 0, NULL);
+	return devm_mfd_add_devices(wm8400->dev, PLATFORM_DEVID_NONE, &cell, 1,
+				    NULL, 0, NULL);
 }
 
 /*