| Message ID | 20200918010521.69950-1-jingxiangfeng@huawei.com |
|---|---|
| State | Superseded |
| Headers | show |
| Series | [v2] fbcon: Remove the superfluous break | expand |
On Fri, Sep 18, 2020 at 09:05:21AM +0800, Jing Xiangfeng wrote: > Remove the superfluous break, as there is a 'return' before it. > > Fixes: bad07ff74c32 ("fbcon: smart blitter usage for scrolling") > Signed-off-by: Jing Xiangfeng <jingxiangfeng@huawei.com> > Reviewed-by: Nick Desaulniers <ndesaulniers@google.com> > Reviewed-by: Gustavo A. R. Silva <gustavoars@kernel.org> Applied to drm-misc-next, thanks. -Daniel > --- > drivers/video/fbdev/core/fbcon.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/drivers/video/fbdev/core/fbcon.c b/drivers/video/fbdev/core/fbcon.c > index 0b49b0f44edf..623359aadd1e 100644 > --- a/drivers/video/fbdev/core/fbcon.c > +++ b/drivers/video/fbdev/core/fbcon.c > @@ -1727,7 +1727,6 @@ static bool fbcon_scroll(struct vc_data *vc, unsigned int t, unsigned int b, > vc->vc_video_erase_char, > vc->vc_size_row * count); > return true; > - break; > > case SCROLL_WRAP_MOVE: > if (b - t - count > 3 * vc->vc_rows >> 2) { > @@ -1818,7 +1817,6 @@ static bool fbcon_scroll(struct vc_data *vc, unsigned int t, unsigned int b, > vc->vc_video_erase_char, > vc->vc_size_row * count); > return true; > - break; > > case SCROLL_WRAP_MOVE: > if (b - t - count > 3 * vc->vc_rows >> 2) { > -- > 2.17.1 > -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch
diff --git a/drivers/video/fbdev/core/fbcon.c b/drivers/video/fbdev/core/fbcon.c index 0b49b0f44edf..623359aadd1e 100644 --- a/drivers/video/fbdev/core/fbcon.c +++ b/drivers/video/fbdev/core/fbcon.c @@ -1727,7 +1727,6 @@ static bool fbcon_scroll(struct vc_data *vc, unsigned int t, unsigned int b, vc->vc_video_erase_char, vc->vc_size_row * count); return true; - break; case SCROLL_WRAP_MOVE: if (b - t - count > 3 * vc->vc_rows >> 2) { @@ -1818,7 +1817,6 @@ static bool fbcon_scroll(struct vc_data *vc, unsigned int t, unsigned int b, vc->vc_video_erase_char, vc->vc_size_row * count); return true; - break; case SCROLL_WRAP_MOVE: if (b - t - count > 3 * vc->vc_rows >> 2) {
Remove the superfluous break, as there is a 'return' before it. Fixes: bad07ff74c32 ("fbcon: smart blitter usage for scrolling") Signed-off-by: Jing Xiangfeng <jingxiangfeng@huawei.com> Reviewed-by: Nick Desaulniers <ndesaulniers@google.com> Reviewed-by: Gustavo A. R. Silva <gustavoars@kernel.org> --- drivers/video/fbdev/core/fbcon.c | 2 -- 1 file changed, 2 deletions(-)