diff mbox

[v2,05/15] ASoC: nuc900: export nuc900_ac97_data

Message ID 1398763412-18928-6-git-send-email-kaixu.xia@linaro.org
State New
Headers show

Commit Message

Xia Kaixu April 29, 2014, 9:23 a.m. UTC 
From: Arnd Bergmann <arnd@arndb.de>

The symbol "nuc900_ac97_data" is used by the nuc900_pcm driver, 
which may be a loadable module, so we should export it.

The option SND_SOC_NUC900 enables support for AC97 mode, so 
select it. 

Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Signed-off-by: Xia Kaixu <kaixu.xia@linaro.org>
Cc: Mark Brown <broonie@kernel.org>
Cc: Liam Girdwood <lgirdwood@gmail.com>
Cc: Wan ZongShun <mcuos.com@gmail.com>
Cc: alsa-devel@alsa-project.org
Cc: linux-arm-kernel@lists.infradead.org
---
 sound/soc/nuc900/Kconfig       |    1 +
 sound/soc/nuc900/nuc900-ac97.c |    1 +
 2 files changed, 2 insertions(+)

Comments

Arnd Bergmann April 29, 2014, 9:35 a.m. UTC | #1 
On Tuesday 29 April 2014 17:23:22 Xia Kaixu wrote:
> 
> The option SND_SOC_NUC900 enables support for AC97 mode, so 
> select it. 
> 

This doesn't really capture the reason for the patch: If one tries
to build SND_SOC_NUC900 without SND_SOC_NUC900_AC97, the kernel
fails to link because of the reference to nuc900_ac97_data.

	Arnd

> diff --git a/sound/soc/nuc900/Kconfig b/sound/soc/nuc900/Kconfig
> index a0ed1c6..7f0c954 100644
> --- a/sound/soc/nuc900/Kconfig
> +++ b/sound/soc/nuc900/Kconfig
> @@ -4,6 +4,7 @@
>  config SND_SOC_NUC900
>         tristate "SoC Audio for NUC900 series"
>         depends on ARCH_W90X900
> +       select SND_SOC_NUC900_AC97
>         help
>           This option enables support for AC97 mode on the NUC900 SoC.
>  
>
diff mbox

Patch

diff --git a/sound/soc/nuc900/Kconfig b/sound/soc/nuc900/Kconfig
index a0ed1c6..7f0c954 100644
--- a/sound/soc/nuc900/Kconfig
+++ b/sound/soc/nuc900/Kconfig
@@ -4,6 +4,7 @@ 
 config SND_SOC_NUC900
 	tristate "SoC Audio for NUC900 series"
 	depends on ARCH_W90X900
+	select SND_SOC_NUC900_AC97
 	help
 	  This option enables support for AC97 mode on the NUC900 SoC.
 
diff --git a/sound/soc/nuc900/nuc900-ac97.c b/sound/soc/nuc900/nuc900-ac97.c
index 8987bf9..f2f6794 100644
--- a/sound/soc/nuc900/nuc900-ac97.c
+++ b/sound/soc/nuc900/nuc900-ac97.c
@@ -28,6 +28,7 @@ 
 
 static DEFINE_MUTEX(ac97_mutex);
 struct nuc900_audio *nuc900_ac97_data;
+EXPORT_SYMBOL_GPL(nuc900_ac97_data);
 
 static int nuc900_checkready(void)
 {