diff mbox series

[v6,2/4] bus: mhi: core: Move MHI_MAX_MTU to external header file

Message ID 1600286167-4432-3-git-send-email-hemantk@codeaurora.org
State Superseded
Headers show
Series user space client interface driver | expand

Commit Message

Hemant Kumar Sept. 16, 2020, 7:56 p.m. UTC
Currently this macro is defined in internal MHI header as
a TRE length mask. Moving it to external header allows MHI
client drivers to set this upper bound for the transmit
buffer size.

Signed-off-by: Hemant Kumar <hemantk@codeaurora.org>
---
 drivers/bus/mhi/core/internal.h | 1 -
 include/linux/mhi.h             | 3 +++
 2 files changed, 3 insertions(+), 1 deletion(-)

Comments

Manivannan Sadhasivam Sept. 27, 2020, 3:14 a.m. UTC | #1
On Wed, Sep 16, 2020 at 12:56:05PM -0700, Hemant Kumar wrote:
> Currently this macro is defined in internal MHI header as

> a TRE length mask. Moving it to external header allows MHI

> client drivers to set this upper bound for the transmit

> buffer size.

> 

> Signed-off-by: Hemant Kumar <hemantk@codeaurora.org>


Reviewed-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>


Thanks,
Mani

> ---

>  drivers/bus/mhi/core/internal.h | 1 -

>  include/linux/mhi.h             | 3 +++

>  2 files changed, 3 insertions(+), 1 deletion(-)

> 

> diff --git a/drivers/bus/mhi/core/internal.h b/drivers/bus/mhi/core/internal.h

> index 7989269..4abf0cf 100644

> --- a/drivers/bus/mhi/core/internal.h

> +++ b/drivers/bus/mhi/core/internal.h

> @@ -453,7 +453,6 @@ enum mhi_pm_state {

>  #define CMD_EL_PER_RING			128

>  #define PRIMARY_CMD_RING		0

>  #define MHI_DEV_WAKE_DB			127

> -#define MHI_MAX_MTU			0xffff

>  #define MHI_RANDOM_U32_NONZERO(bmsk)	(prandom_u32_max(bmsk) + 1)

>  

>  enum mhi_er_type {

> diff --git a/include/linux/mhi.h b/include/linux/mhi.h

> index 6565528..610f3b0 100644

> --- a/include/linux/mhi.h

> +++ b/include/linux/mhi.h

> @@ -16,6 +16,9 @@

>  #include <linux/wait.h>

>  #include <linux/workqueue.h>

>  

> +/* MHI client drivers to set this upper bound for tx buffer */

> +#define MHI_MAX_MTU 0xffff

> +

>  #define MHI_MAX_OEM_PK_HASH_SEGMENTS 16

>  

>  struct mhi_chan;

> -- 

> The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,

> a Linux Foundation Collaborative Project

>
diff mbox series

Patch

diff --git a/drivers/bus/mhi/core/internal.h b/drivers/bus/mhi/core/internal.h
index 7989269..4abf0cf 100644
--- a/drivers/bus/mhi/core/internal.h
+++ b/drivers/bus/mhi/core/internal.h
@@ -453,7 +453,6 @@  enum mhi_pm_state {
 #define CMD_EL_PER_RING			128
 #define PRIMARY_CMD_RING		0
 #define MHI_DEV_WAKE_DB			127
-#define MHI_MAX_MTU			0xffff
 #define MHI_RANDOM_U32_NONZERO(bmsk)	(prandom_u32_max(bmsk) + 1)
 
 enum mhi_er_type {
diff --git a/include/linux/mhi.h b/include/linux/mhi.h
index 6565528..610f3b0 100644
--- a/include/linux/mhi.h
+++ b/include/linux/mhi.h
@@ -16,6 +16,9 @@ 
 #include <linux/wait.h>
 #include <linux/workqueue.h>
 
+/* MHI client drivers to set this upper bound for tx buffer */
+#define MHI_MAX_MTU 0xffff
+
 #define MHI_MAX_OEM_PK_HASH_SEGMENTS 16
 
 struct mhi_chan;