| Message ID | 20200929180859.3477990-1-jacob.e.keller@intel.com |
|---|---|
| State | New |
| Headers | show |
| Series | [net-next] devlink: include <linux/const.h> for _BITUL | expand |
From: Jacob Keller <jacob.e.keller@intel.com> Date: Tue, 29 Sep 2020 11:08:59 -0700 > Commit 5d5b4128c4ca ("devlink: introduce flash update overwrite mask") > added a usage of _BITUL to the UAPI <linux/devlink.h> header, but failed > to include the header file where it was defined. It happens that this > does not break any existing kernel include chains because it gets > included through other sources. However, when including the UAPI headers > in a userspace application (such as devlink in iproute2), _BITUL is not > defined. > > Fixes: 5d5b4128c4ca ("devlink: introduce flash update overwrite mask") > Signed-off-by: Jacob Keller <jacob.e.keller@intel.com> Applied.
diff --git a/include/uapi/linux/devlink.h b/include/uapi/linux/devlink.h index 7b0face1bad5..ba467dc07852 100644 --- a/include/uapi/linux/devlink.h +++ b/include/uapi/linux/devlink.h @@ -13,6 +13,8 @@ #ifndef _UAPI_LINUX_DEVLINK_H_ #define _UAPI_LINUX_DEVLINK_H_ +#include <linux/const.h> + #define DEVLINK_GENL_NAME "devlink" #define DEVLINK_GENL_VERSION 0x1 #define DEVLINK_GENL_MCGRP_CONFIG_NAME "config"
Commit 5d5b4128c4ca ("devlink: introduce flash update overwrite mask") added a usage of _BITUL to the UAPI <linux/devlink.h> header, but failed to include the header file where it was defined. It happens that this does not break any existing kernel include chains because it gets included through other sources. However, when including the UAPI headers in a userspace application (such as devlink in iproute2), _BITUL is not defined. Fixes: 5d5b4128c4ca ("devlink: introduce flash update overwrite mask") Signed-off-by: Jacob Keller <jacob.e.keller@intel.com> --- I believe this is the appropriate fix for the issue Dave reported at [1], vs working around it by including uapi/linux/const.h in the devlink.c file in iproute2. [1] https://lore.kernel.org/netdev/198b8a34-49de-88e8-629c-408e592f42a6@gmail.com/ include/uapi/linux/devlink.h | 2 ++ 1 file changed, 2 insertions(+) base-commit: 280095713ce244e8dbdfb059cdca695baa72230a