diff mbox

[03/13] video: clarify I2C dependencies

Message ID 1398274127-2106-3-git-send-email-peter.griffin@linaro.org
State New
Headers show

Commit Message

Peter Griffin April 23, 2014, 5:28 p.m. UTC 
From: Arnd Bergmann <arnd@arndb.de>

We can only use I2C support in frame buffer drivers if
Either I2C is built-in, or both I2C and the driver itself
are loadable modules.

Fix this dependency for MB862XX and CyberPro frame buffers.

Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Signed-off-by: Peter Griffin <peter.griffin@linaro.org>
Cc: Jean-Christophe Plagniol-Villard <plagnioj@jcrosoft.com>
Cc: Tomi Valkeinen <tomi.valkeinen@ti.com>
Cc: linux-fbdev@vger.kernel.org
---
 drivers/video/fbdev/Kconfig |    2 ++
 1 file changed, 2 insertions(+)

Comments

Arnd Bergmann April 23, 2014, 6:26 p.m. UTC | #1 
On Wednesday 23 April 2014 18:28:37 Peter Griffin wrote:
> From: Arnd Bergmann <arnd@arndb.de>
> 
> We can only use I2C support in frame buffer drivers if
> Either I2C is built-in, or both I2C and the driver itself
> are loadable modules.
> 
> Fix this dependency for MB862XX and CyberPro frame buffers.
> 
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> Signed-off-by: Peter Griffin <peter.griffin@linaro.org>
> Cc: Jean-Christophe Plagniol-Villard <plagnioj@jcrosoft.com>
> Cc: Tomi Valkeinen <tomi.valkeinen@ti.com>
> Cc: linux-fbdev@vger.kernel.org

It makes sense to Cc the maintainers for the two drivers here.
Unfortunately scripts/get_maintainer.pl seems to fail because
the files recently moved. If you use git log --follow, you will
find that Russell King and Anatolij Gustschin, respectively,
maintain these drivers.

	Arnd
diff mbox

Patch

diff --git a/drivers/video/fbdev/Kconfig b/drivers/video/fbdev/Kconfig
index a4116bf..5577a94 100644
--- a/drivers/video/fbdev/Kconfig
+++ b/drivers/video/fbdev/Kconfig
@@ -360,6 +360,7 @@  config FB_CYBER2000_DDC
 config FB_CYBER2000_I2C
 	bool "CyberPro 2000/2010/5000 I2C support"
 	depends on FB_CYBER2000 && I2C && ARCH_NETWINDER
+	depends on I2C=y || FB_CYBER2000=m
 	select I2C_ALGOBIT
 	help
 	  Enable support for the I2C video decoder interface on the
@@ -2296,6 +2297,7 @@  endchoice
 config FB_MB862XX_I2C
 	bool "Support I2C bus on MB862XX GDC"
 	depends on FB_MB862XX && I2C
+	depends on FB_MB862XX=m || I2C=y
 	default y
 	help
 	  Selecting this option adds Coral-P(A)/Lime GDC I2C bus adapter