| Message ID | 20200714105113.32603-1-mjt@msgid.tls.msk.ru |
|---|---|
| State | Superseded |
| Headers | show |
| Series | [v2,for-5.1] acpi-pm-tmr: allow any small-size reads | expand |
diff --git a/hw/acpi/core.c b/hw/acpi/core.c --- a/hw/acpi/core.c +++ b/hw/acpi/core.c @@ -530,7 +530,10 @@ static void acpi_pm_tmr_write(void *opaque, hwaddr addr, uint64_t val, static const MemoryRegionOps acpi_pm_tmr_ops = { .read = acpi_pm_tmr_read, .write = acpi_pm_tmr_write, - .valid.min_access_size = 4, + .impl.min_access_size = 4, + /* at least MacOS Catalina reads 2 bytes and fails if it doesn't work */ + /* allow 1-byte reads too */ + .valid.min_access_size = 1, .valid.max_access_size = 4, .endianness = DEVICE_LITTLE_ENDIAN, };
As found in LP#1886318, MacOS Catalina performs 2-byte reads on the acpi timer address space while the spec says it should be 4-byte. Allow any small reads. Reported-By: Simon John <git@the-jedi.co.uk> Signed-off-by: Michael Tokarev <mjt@tls.msk.ru> --- hw/acpi/core.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) v2: fixed bug#, use the right form of S-o-b, and allow up to 1 byte reads. I'm applying this to debian qemu package, need the fix faster in order to release security updates for other branches.