diff mbox series

[v2] cpus: Do not dump CPU state when calling hw_error()

Message ID 20201001175531.1623361-1-f4bug@amsat.org
State Superseded
Headers show
Series [v2] cpus: Do not dump CPU state when calling hw_error() | expand

Commit Message

Philippe Mathieu-Daudé Oct. 1, 2020, 5:55 p.m. UTC 
Dumping the state of all CPUs is not helpful in any of the contexts
where hw_error() is used.
We already have cpu_abort() to dump CPU states and abort.

Restrict hw_error() to peripheral errors, hoping we can completely
remove it by proper functions from "error-report.h" in the future.

Reviewed-by: Thomas Huth <thuth@redhat.com>
Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
---
 softmmu/cpus.c | 5 -----
 1 file changed, 5 deletions(-)
diff mbox series

Patch

diff --git a/softmmu/cpus.c b/softmmu/cpus.c
index ac8940d52e..da45cbf989 100644
--- a/softmmu/cpus.c
+++ b/softmmu/cpus.c
@@ -913,16 +913,11 @@  static void stop_tcg_kick_timer(void)
 void hw_error(const char *fmt, ...)
 {
     va_list ap;
-    CPUState *cpu;
 
     va_start(ap, fmt);
     fprintf(stderr, "qemu: hardware error: ");
     vfprintf(stderr, fmt, ap);
     fprintf(stderr, "\n");
-    CPU_FOREACH(cpu) {
-        fprintf(stderr, "CPU #%d:\n", cpu->cpu_index);
-        cpu_dump_state(cpu, stderr, CPU_DUMP_FPU);
-    }
     va_end(ap);
     abort();
 }