| Message ID | 20201005195158.2348217-14-jsnow@redhat.com |
|---|---|
| State | Superseded |
| Headers | show |
| Series | qapi: static typing conversion, pt1 | expand |
On 10/5/20 9:51 PM, John Snow wrote: > Signed-off-by: John Snow <jsnow@redhat.com> > Reviewed-by: Cleber Rosa <crosa@redhat.com> > Reviewed-by: Eduardo Habkost <ehabkost@redhat.com> > --- > scripts/qapi/common.py | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/scripts/qapi/common.py b/scripts/qapi/common.py > index a417b6029c8..338adedef4f 100644 > --- a/scripts/qapi/common.py > +++ b/scripts/qapi/common.py > @@ -30,14 +30,14 @@ def camel_to_upper(value): > new_name = '' > length = len(c_fun_str) > for i in range(length): > - c = c_fun_str[i] > - # When c is upper and no '_' appears before, do more checks > - if c.isupper() and (i > 0) and c_fun_str[i - 1] != '_': > + char = c_fun_str[i] > + # When char is upper case and no '_' appears before, do more checks > + if char.isupper() and (i > 0) and c_fun_str[i - 1] != '_': > if i < length - 1 and c_fun_str[i + 1].islower(): > new_name += '_' > elif c_fun_str[i - 1].isdigit(): > new_name += '_' > - new_name += c > + new_name += char > return new_name.lstrip('_').upper() Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
diff --git a/scripts/qapi/common.py b/scripts/qapi/common.py index a417b6029c8..338adedef4f 100644 --- a/scripts/qapi/common.py +++ b/scripts/qapi/common.py @@ -30,14 +30,14 @@ def camel_to_upper(value): new_name = '' length = len(c_fun_str) for i in range(length): - c = c_fun_str[i] - # When c is upper and no '_' appears before, do more checks - if c.isupper() and (i > 0) and c_fun_str[i - 1] != '_': + char = c_fun_str[i] + # When char is upper case and no '_' appears before, do more checks + if char.isupper() and (i > 0) and c_fun_str[i - 1] != '_': if i < length - 1 and c_fun_str[i + 1].islower(): new_name += '_' elif c_fun_str[i - 1].isdigit(): new_name += '_' - new_name += c + new_name += char return new_name.lstrip('_').upper()