| Message ID | 20201014072555.12515-8-chen.zhang@intel.com |
|---|---|
| State | Superseded |
| Headers | show |
| Series | COLO project queued patches 20-Oct | expand |
On 10/14/20 9:25 AM, Zhang Chen wrote: > From: Zhang Chen <chen.zhang@intel.com> > > This parameter need compare with the return of qemu_clock_get_ms(), > it is uinit64_t. So we need fix this issue here. Typo "uint64_t" Please add: Fixes: 9cc43c94b31 ("net/colo-compare.c: Expose "compare_timeout" to users") Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com> > > Reported-by: Derek Su <dereksu@qnap.com> > Signed-off-by: Zhang Chen <chen.zhang@intel.com> > Reviewed-by: Li Zhijian <lizhijian@cn.fujitsu.com> > --- > net/colo-compare.c | 12 ++++++------ > 1 file changed, 6 insertions(+), 6 deletions(-) > > diff --git a/net/colo-compare.c b/net/colo-compare.c > index 24c366eec0..f4814c5f09 100644 > --- a/net/colo-compare.c > +++ b/net/colo-compare.c > @@ -120,7 +120,7 @@ struct CompareState { > SendCo out_sendco; > SendCo notify_sendco; > bool vnet_hdr; > - uint32_t compare_timeout; > + uint64_t compare_timeout; > uint32_t expired_scan_cycle; > > /* > @@ -1075,9 +1075,9 @@ static void compare_get_timeout(Object *obj, Visitor *v, > Error **errp) > { > CompareState *s = COLO_COMPARE(obj); > - uint32_t value = s->compare_timeout; > + uint64_t value = s->compare_timeout; > > - visit_type_uint32(v, name, &value, errp); > + visit_type_uint64(v, name, &value, errp); > } > > static void compare_set_timeout(Object *obj, Visitor *v, > @@ -1140,9 +1140,9 @@ static void set_max_queue_size(Object *obj, Visitor *v, > Error **errp) > { > Error *local_err = NULL; > - uint32_t value; > + uint64_t value; > > - visit_type_uint32(v, name, &value, &local_err); > + visit_type_uint64(v, name, &value, &local_err); > if (local_err) { > goto out; > } > @@ -1390,7 +1390,7 @@ static void colo_compare_init(Object *obj) > object_property_add_str(obj, "notify_dev", > compare_get_notify_dev, compare_set_notify_dev); > > - object_property_add(obj, "compare_timeout", "uint32", > + object_property_add(obj, "compare_timeout", "uint64", > compare_get_timeout, > compare_set_timeout, NULL, NULL); > >
diff --git a/net/colo-compare.c b/net/colo-compare.c index 24c366eec0..f4814c5f09 100644 --- a/net/colo-compare.c +++ b/net/colo-compare.c @@ -120,7 +120,7 @@ struct CompareState { SendCo out_sendco; SendCo notify_sendco; bool vnet_hdr; - uint32_t compare_timeout; + uint64_t compare_timeout; uint32_t expired_scan_cycle; /* @@ -1075,9 +1075,9 @@ static void compare_get_timeout(Object *obj, Visitor *v, Error **errp) { CompareState *s = COLO_COMPARE(obj); - uint32_t value = s->compare_timeout; + uint64_t value = s->compare_timeout; - visit_type_uint32(v, name, &value, errp); + visit_type_uint64(v, name, &value, errp); } static void compare_set_timeout(Object *obj, Visitor *v, @@ -1140,9 +1140,9 @@ static void set_max_queue_size(Object *obj, Visitor *v, Error **errp) { Error *local_err = NULL; - uint32_t value; + uint64_t value; - visit_type_uint32(v, name, &value, &local_err); + visit_type_uint64(v, name, &value, &local_err); if (local_err) { goto out; } @@ -1390,7 +1390,7 @@ static void colo_compare_init(Object *obj) object_property_add_str(obj, "notify_dev", compare_get_notify_dev, compare_set_notify_dev); - object_property_add(obj, "compare_timeout", "uint32", + object_property_add(obj, "compare_timeout", "uint64", compare_get_timeout, compare_set_timeout, NULL, NULL);