| Message ID | 1395766541-23979-25-git-send-email-julien.grall@linaro.org |
|---|---|
| State | Deferred, archived |
| Headers | show |
On Tue, 2014-03-25 at 16:55 +0000, Julien Grall wrote: "only used internally" is an odd way to put it. Something like "is only used from within the file and can therefore be static" perhaps? > Signed-off-by: Julien Grall <julien.grall@linaro.org> Acked-by: Ian Campbell <ian.campbell@citrix.com>
On 03/27/2014 05:07 PM, Ian Campbell wrote: > On Tue, 2014-03-25 at 16:55 +0000, Julien Grall wrote: > > "only used internally" is an odd way to put it. Something like "is only > used from within the file and can therefore be static" perhaps? Right, I was unable to find a good description when I wrote the different patches. I will rework all the commit messages with "only used internally" in the title. >> Signed-off-by: Julien Grall <julien.grall@linaro.org> > > Acked-by: Ian Campbell <ian.campbell@citrix.com> Thanks,
diff --git a/xen/arch/arm/setup.c b/xen/arch/arm/setup.c index 08be416..3806429 100644 --- a/xen/arch/arm/setup.c +++ b/xen/arch/arm/setup.c @@ -642,7 +642,7 @@ static void __init setup_mm(unsigned long dtb_paddr, size_t dtb_size) size_t __read_mostly cacheline_bytes; /* Very early check of the CPU cache properties */ -void __init setup_cache(void) +static void __init setup_cache(void) { uint32_t ccsid;
Signed-off-by: Julien Grall <julien.grall@linaro.org> Cc: Ian Campbell <ian.campbell@citrix.com> Cc: Stefano Stabellini <stefano.stabellini@citrix.com> Cc: Tim Deegan <tim@xen.org> --- xen/arch/arm/setup.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)