diff mbox

[Xen-devel,07/34] xen/common: sched_sedf: Remove unused functions

Message ID 1395766541-23979-8-git-send-email-julien.grall@linaro.org
State Accepted, archived
Headers show

Commit Message

Julien Grall March 25, 2014, 4:55 p.m. UTC 
Clang 3.5 will fail to compile xen/common/sched_sedf.c because some function
are not used:

sched_sedf.c:141:20: error: unused function 'extraq_add_head' [-Werror,-Wunused-function]
static inline void extraq_add_head(struct vcpu *d, int i)
                       ^
sched_sedf.c:147:20: error: unused function 'extraq_add_tail' [-Werror,-Wunused-function]
static inline void extraq_add_tail(struct vcpu *d, int i)

Signed-off-by: Julien Grall <julien.grall@linaro.org>
Cc: George Dunlap <george.dunlap@eu.citrix.com>
---
 xen/common/sched_sedf.c |   12 ------------
 1 file changed, 12 deletions(-)

Comments

George Dunlap March 25, 2014, 5:03 p.m. UTC | #1 
On 03/25/2014 04:55 PM, Julien Grall wrote:
> Clang 3.5 will fail to compile xen/common/sched_sedf.c because some function
> are not used:
>
> sched_sedf.c:141:20: error: unused function 'extraq_add_head' [-Werror,-Wunused-function]
> static inline void extraq_add_head(struct vcpu *d, int i)
>                         ^
> sched_sedf.c:147:20: error: unused function 'extraq_add_tail' [-Werror,-Wunused-function]
> static inline void extraq_add_tail(struct vcpu *d, int i)
>
> Signed-off-by: Julien Grall <julien.grall@linaro.org>
> Cc: George Dunlap <george.dunlap@eu.citrix.com>

Acked-by: George Dunlap <george.dunlap@eu.citrix.com>

> ---
>   xen/common/sched_sedf.c |   12 ------------
>   1 file changed, 12 deletions(-)
>
> diff --git a/xen/common/sched_sedf.c b/xen/common/sched_sedf.c
> index 7c24171..0c9011a 100644
> --- a/xen/common/sched_sedf.c
> +++ b/xen/common/sched_sedf.c
> @@ -138,18 +138,6 @@ static inline int extraq_on(struct vcpu *d, int i)
>               (EXTRALIST(d,i)->next != EXTRALIST(d,i)));
>   }
>
> -static inline void extraq_add_head(struct vcpu *d, int i)
> -{
> -    list_add(EXTRALIST(d,i), EXTRAQ(d->processor,i));
> -    ASSERT(extraq_on(d, i));
> -}
> -
> -static inline void extraq_add_tail(struct vcpu *d, int i)
> -{
> -    list_add_tail(EXTRALIST(d,i), EXTRAQ(d->processor,i));
> -    ASSERT(extraq_on(d, i));
> -}
> -
>   static inline void extraq_del(struct vcpu *d, int i)
>   {
>       struct list_head *list = EXTRALIST(d,i);
>
diff mbox

Patch

diff --git a/xen/common/sched_sedf.c b/xen/common/sched_sedf.c
index 7c24171..0c9011a 100644
--- a/xen/common/sched_sedf.c
+++ b/xen/common/sched_sedf.c
@@ -138,18 +138,6 @@  static inline int extraq_on(struct vcpu *d, int i)
             (EXTRALIST(d,i)->next != EXTRALIST(d,i)));
 }
 
-static inline void extraq_add_head(struct vcpu *d, int i)
-{
-    list_add(EXTRALIST(d,i), EXTRAQ(d->processor,i));
-    ASSERT(extraq_on(d, i));
-}
-
-static inline void extraq_add_tail(struct vcpu *d, int i)
-{
-    list_add_tail(EXTRALIST(d,i), EXTRAQ(d->processor,i));
-    ASSERT(extraq_on(d, i));
-}
-
 static inline void extraq_del(struct vcpu *d, int i)
 {
     struct list_head *list = EXTRALIST(d,i);