| Message ID | 1602407979-29038-5-git-send-email-Julia.Lawall@inria.fr |
|---|---|
| State | Accepted |
| Commit | fe160a22aa2dc558d819660d41e08b86f041cc77 |
| Headers | show |
| Series | use semicolons rather than commas to separate statements | expand |
Hi, On Sun, Oct 11, 2020 at 11:19:35AM +0200, Julia Lawall wrote: > Replace commas with semicolons. What is done is essentially described by > the following Coccinelle semantic patch (http://coccinelle.lip6.fr/): > > // <smpl> > @@ expression e1,e2; @@ > e1 > -, > +; > e2 > ... when any > // </smpl> > > Signed-off-by: Julia Lawall <Julia.Lawall@inria.fr> > > --- > sound/firewire/fireworks/fireworks_pcm.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/sound/firewire/fireworks/fireworks_pcm.c b/sound/firewire/fireworks/fireworks_pcm.c > index 980580dfbb39..a0d5db1d8eb2 100644 > --- a/sound/firewire/fireworks/fireworks_pcm.c > +++ b/sound/firewire/fireworks/fireworks_pcm.c > @@ -148,7 +148,7 @@ pcm_init_hw_params(struct snd_efw *efw, > } > > /* limit rates */ > - runtime->hw.rates = efw->supported_sampling_rate, > + runtime->hw.rates = efw->supported_sampling_rate; > snd_pcm_limit_hw_rates(runtime); > > limit_channels(&runtime->hw, pcm_channels); Oops. It seems to be my typo added at the commit aa02bb6e6078 ("ALSA: fireworks: Add PCM interface")... Acked-by: Takashi Sakamoto <o-takashi@sakamocchi.jp> Thanks Takashi Sakamoto
On Sun, 11 Oct 2020 11:19:35 +0200, Julia Lawall wrote: > > Replace commas with semicolons. What is done is essentially described by > the following Coccinelle semantic patch (http://coccinelle.lip6.fr/): > > // <smpl> > @@ expression e1,e2; @@ > e1 > -, > +; > e2 > ... when any > // </smpl> > > Signed-off-by: Julia Lawall <Julia.Lawall@inria.fr> Applied now. Thanks. Takashi
diff --git a/sound/firewire/fireworks/fireworks_pcm.c b/sound/firewire/fireworks/fireworks_pcm.c index 980580dfbb39..a0d5db1d8eb2 100644 --- a/sound/firewire/fireworks/fireworks_pcm.c +++ b/sound/firewire/fireworks/fireworks_pcm.c @@ -148,7 +148,7 @@ pcm_init_hw_params(struct snd_efw *efw, } /* limit rates */ - runtime->hw.rates = efw->supported_sampling_rate, + runtime->hw.rates = efw->supported_sampling_rate; snd_pcm_limit_hw_rates(runtime); limit_channels(&runtime->hw, pcm_channels);
Replace commas with semicolons. What is done is essentially described by the following Coccinelle semantic patch (http://coccinelle.lip6.fr/): // <smpl> @@ expression e1,e2; @@ e1 -, +; e2 ... when any // </smpl> Signed-off-by: Julia Lawall <Julia.Lawall@inria.fr> --- sound/firewire/fireworks/fireworks_pcm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)