| Message ID | 1395677644-29552-1-git-send-email-peter.maydell@linaro.org |
|---|---|
| State | Superseded |
| Headers | show |
On Mon, Mar 24, 2014 at 5:14 PM, Peter Maydell <peter.maydell@linaro.org> wrote: > The order of operands for the accumulate step in disas_simd_3same_int() > was reversed. This only affected the MLS instruction, since all the > other accumulating instructions in this category perform an addition > rather than a subtraction. > > Reported-by: Laurent Desnogues <laurent.desnogues@gmail.com> > Signed-off-by: Peter Maydell <peter.maydell@linaro.org> Tested-by: Laurent Desnogues <laurent.desnogues@gmail.com> Thanks, Laurent > --- > Bit embarrassing, not sure how this slipped through the testing > process (the test risu binary I have for MLS failed as expected, > so I must just have forgotten to run/rerun it somehow.) > > target-arm/translate-a64.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/target-arm/translate-a64.c b/target-arm/translate-a64.c > index 9f06450..9175e48 100644 > --- a/target-arm/translate-a64.c > +++ b/target-arm/translate-a64.c > @@ -8925,7 +8925,7 @@ static void disas_simd_3same_int(DisasContext *s, uint32_t insn) > > genfn = fns[size][is_sub]; > read_vec_element_i32(s, tcg_op1, rd, pass, MO_32); > - genfn(tcg_res, tcg_res, tcg_op1); > + genfn(tcg_res, tcg_op1, tcg_res); > } > > write_vec_element_i32(s, tcg_res, rd, pass, MO_32); > -- > 1.9.0 >
diff --git a/target-arm/translate-a64.c b/target-arm/translate-a64.c index 9f06450..9175e48 100644 --- a/target-arm/translate-a64.c +++ b/target-arm/translate-a64.c @@ -8925,7 +8925,7 @@ static void disas_simd_3same_int(DisasContext *s, uint32_t insn) genfn = fns[size][is_sub]; read_vec_element_i32(s, tcg_op1, rd, pass, MO_32); - genfn(tcg_res, tcg_res, tcg_op1); + genfn(tcg_res, tcg_op1, tcg_res); } write_vec_element_i32(s, tcg_res, rd, pass, MO_32);
The order of operands for the accumulate step in disas_simd_3same_int() was reversed. This only affected the MLS instruction, since all the other accumulating instructions in this category perform an addition rather than a subtraction. Reported-by: Laurent Desnogues <laurent.desnogues@gmail.com> Signed-off-by: Peter Maydell <peter.maydell@linaro.org> --- Bit embarrassing, not sure how this slipped through the testing process (the test risu binary I have for MLS failed as expected, so I must just have forgotten to run/rerun it somehow.) target-arm/translate-a64.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)