| Message ID | 20201002062051.8551-1-kurt@linutronix.de |
|---|---|
| State | New |
| Headers | show |
| Series | [net-next] dt-bindings: net: dsa: b53: Add missing reg property to example | expand |
On Fri, Oct 02, 2020 at 08:20:51AM +0200, Kurt Kanzenbach wrote: > The switch has a certain MDIO address and this needs to be specified using the > reg property. Add it to the example. > > Signed-off-by: Kurt Kanzenbach <kurt@linutronix.de> Reviewed-by: Andrew Lunn <andrew@lunn.ch> Andrew
On 10/1/2020 11:20 PM, Kurt Kanzenbach wrote: > The switch has a certain MDIO address and this needs to be specified using the > reg property. Add it to the example. > > Signed-off-by: Kurt Kanzenbach <kurt@linutronix.de> > --- > Documentation/devicetree/bindings/net/dsa/b53.txt | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/Documentation/devicetree/bindings/net/dsa/b53.txt b/Documentation/devicetree/bindings/net/dsa/b53.txt > index cfd1afdc6e94..80437b2fc935 100644 > --- a/Documentation/devicetree/bindings/net/dsa/b53.txt > +++ b/Documentation/devicetree/bindings/net/dsa/b53.txt > @@ -106,6 +106,7 @@ Ethernet switch connected via MDIO to the host, CPU port wired to eth0: > > switch0: ethernet-switch@30 { This should actually be 1e because the unit address is supposed to be in hexadecimal. > compatible = "brcm,bcm53125"; > + reg = <30>; however this one is correct, if you want to resend with the unit address fixed that would be fine, if not: Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
From: Kurt Kanzenbach <kurt@linutronix.de> Date: Fri, 2 Oct 2020 08:20:51 +0200 > The switch has a certain MDIO address and this needs to be specified using the > reg property. Add it to the example. > > Signed-off-by: Kurt Kanzenbach <kurt@linutronix.de> Applied, thank you.
On Fri Oct 02 2020, Florian Fainelli wrote: > On 10/1/2020 11:20 PM, Kurt Kanzenbach wrote: >> The switch has a certain MDIO address and this needs to be specified using the >> reg property. Add it to the example. >> >> Signed-off-by: Kurt Kanzenbach <kurt@linutronix.de> >> --- >> Documentation/devicetree/bindings/net/dsa/b53.txt | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/Documentation/devicetree/bindings/net/dsa/b53.txt b/Documentation/devicetree/bindings/net/dsa/b53.txt >> index cfd1afdc6e94..80437b2fc935 100644 >> --- a/Documentation/devicetree/bindings/net/dsa/b53.txt >> +++ b/Documentation/devicetree/bindings/net/dsa/b53.txt >> @@ -106,6 +106,7 @@ Ethernet switch connected via MDIO to the host, CPU port wired to eth0: >> >> switch0: ethernet-switch@30 { > > This should actually be 1e because the unit address is supposed to be in > hexadecimal. OK. > >> compatible = "brcm,bcm53125"; >> + reg = <30>; > > however this one is correct, if you want to resend with the unit address > fixed that would be fine, if not: Just noticed another problem in the example: The fixed link is specified with "duplex-full" instead of "full-duplex" leading to half speed. So, I'll send another patch and fix the above along with it. Thanks, Kurt
diff --git a/Documentation/devicetree/bindings/net/dsa/b53.txt b/Documentation/devicetree/bindings/net/dsa/b53.txt index cfd1afdc6e94..80437b2fc935 100644 --- a/Documentation/devicetree/bindings/net/dsa/b53.txt +++ b/Documentation/devicetree/bindings/net/dsa/b53.txt @@ -106,6 +106,7 @@ Ethernet switch connected via MDIO to the host, CPU port wired to eth0: switch0: ethernet-switch@30 { compatible = "brcm,bcm53125"; + reg = <30>; #address-cells = <1>; #size-cells = <0>;
The switch has a certain MDIO address and this needs to be specified using the reg property. Add it to the example. Signed-off-by: Kurt Kanzenbach <kurt@linutronix.de> --- Documentation/devicetree/bindings/net/dsa/b53.txt | 1 + 1 file changed, 1 insertion(+)