| Message ID | 20201003093051.7242-1-kurt@linutronix.de |
|---|---|
| State | New |
| Headers | show |
| Series | [net-next,1/2] dt-bindings: net: dsa: b53: Specify unit address in hex | expand |
On 10/3/2020 2:30 AM, Kurt Kanzenbach wrote: > The unit address should be 1e, because the unit address is supposed > to be in hexadecimal. > > Suggested-by: Florian Fainelli <f.fainelli@gmail.com> > Signed-off-by: Kurt Kanzenbach <kurt@linutronix.de> Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
From: Kurt Kanzenbach <kurt@linutronix.de> Date: Sat, 3 Oct 2020 11:30:50 +0200 > The unit address should be 1e, because the unit address is supposed > to be in hexadecimal. > > Suggested-by: Florian Fainelli <f.fainelli@gmail.com> > Signed-off-by: Kurt Kanzenbach <kurt@linutronix.de> Applied.
On Sat Oct 03 2020, Florian Fainelli wrote: > On 10/3/2020 2:30 AM, Kurt Kanzenbach wrote: >> There is no such property as duplex-full. It's called full-duplex. Leading to >> reduced speed when using the example as base for a real device tree. > > Doh, thanks for correcting this. Would you want to make this a YAML > binding at some point? I can take care of it if you do not have time to > do it. Actually I have started to convert the DSA bindings to YAML, but ran out of time very quickly. Unfortunately the b53 wasn't one of them I've converted already. So, you can go ahead. Thanks, Kurt
diff --git a/Documentation/devicetree/bindings/net/dsa/b53.txt b/Documentation/devicetree/bindings/net/dsa/b53.txt index 80437b2fc935..3bb4e1086913 100644 --- a/Documentation/devicetree/bindings/net/dsa/b53.txt +++ b/Documentation/devicetree/bindings/net/dsa/b53.txt @@ -104,7 +104,7 @@ Ethernet switch connected via MDIO to the host, CPU port wired to eth0: #address-cells = <1>; #size-cells = <0>; - switch0: ethernet-switch@30 { + switch0: ethernet-switch@1e { compatible = "brcm,bcm53125"; reg = <30>; #address-cells = <1>;
The unit address should be 1e, because the unit address is supposed to be in hexadecimal. Suggested-by: Florian Fainelli <f.fainelli@gmail.com> Signed-off-by: Kurt Kanzenbach <kurt@linutronix.de> --- Documentation/devicetree/bindings/net/dsa/b53.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)