| Message ID | 20201001202725.16034-1-grygorii.strashko@ti.com |
|---|---|
| State | New |
| Headers | show |
| Series | ARM: multi_v7_defconfig: ti: Enable networking options for nfs boot | expand |
On 23:27-20201001, Grygorii Strashko wrote: > Enable networking options required for NFS boot on TI platforms, which is > widely for automated test systems. > - enable new TI CPSW switch driver and related NET_SWITCHDEV config > - enable TI DP83867 phy > - explicitly enable PTP clock support to ensure dependent networking > drivers will stay built-in > > Signed-off-by: Grygorii Strashko <grygorii.strashko@ti.com> > --- > arch/arm/configs/multi_v7_defconfig | 5 +++++ > 1 file changed, 5 insertions(+) > [...] Reviewed-by: Nishanth Menon <nm@ti.com>
Hi All, On 02/10/2020 15:50, Nishanth Menon wrote: > On 23:27-20201001, Grygorii Strashko wrote: >> Enable networking options required for NFS boot on TI platforms, which is >> widely for automated test systems. >> - enable new TI CPSW switch driver and related NET_SWITCHDEV config >> - enable TI DP83867 phy >> - explicitly enable PTP clock support to ensure dependent networking >> drivers will stay built-in >> >> Signed-off-by: Grygorii Strashko <grygorii.strashko@ti.com> >> --- >> arch/arm/configs/multi_v7_defconfig | 5 +++++ >> 1 file changed, 5 insertions(+) >> > > [...] > > Reviewed-by: Nishanth Menon <nm@ti.com> > Are there any actions need to be done to have this patch merged? -- Best regards, grygorii
On Thu, Oct 29, 2020 at 8:15 PM Grygorii Strashko <grygorii.strashko@ti.com> wrote: > On 02/10/2020 15:50, Nishanth Menon wrote: > > On 23:27-20201001, Grygorii Strashko wrote: > >> Enable networking options required for NFS boot on TI platforms, which is > >> widely for automated test systems. > >> - enable new TI CPSW switch driver and related NET_SWITCHDEV config > >> - enable TI DP83867 phy > >> - explicitly enable PTP clock support to ensure dependent networking > >> drivers will stay built-in > >> > >> Signed-off-by: Grygorii Strashko <grygorii.strashko@ti.com> > >> --- > >> arch/arm/configs/multi_v7_defconfig | 5 +++++ > >> 1 file changed, 5 insertions(+) > >> > > > > [...] > > > > Reviewed-by: Nishanth Menon <nm@ti.com> > > > > Are there any actions need to be done to have this patch merged? I would prefer if a platform maintainer (I assume Tony in this case) picks it up and forwards it to soc@kernel.org together with other related changes. Olof and I tend to ignore patches sent directly to us, so we don't get in the way of platform maintainers that may have already merged similar patches or have comments. I suspect Tony didn't pick it up either because from the patch subject and the description, it is not clear that he is the one to act on it. It helps to be more specific and ask the maintainer by addressing them in person below the '---' line, as well as only putting one person in 'To:' and the rest in 'Cc:'. One comment on the contents of the patch: IIRC this is a fairly large driver. To ensure we don't burden other users too much, can you include the size of the vmlinux file before and after this patch? Arnd
Hi Arnd, On 29/10/2020 22:06, Arnd Bergmann wrote: > On Thu, Oct 29, 2020 at 8:15 PM Grygorii Strashko > <grygorii.strashko@ti.com> wrote: >> On 02/10/2020 15:50, Nishanth Menon wrote: >>> On 23:27-20201001, Grygorii Strashko wrote: >>>> Enable networking options required for NFS boot on TI platforms, which is >>>> widely for automated test systems. >>>> - enable new TI CPSW switch driver and related NET_SWITCHDEV config >>>> - enable TI DP83867 phy >>>> - explicitly enable PTP clock support to ensure dependent networking >>>> drivers will stay built-in >>>> >>>> Signed-off-by: Grygorii Strashko <grygorii.strashko@ti.com> >>>> --- >>>> arch/arm/configs/multi_v7_defconfig | 5 +++++ >>>> 1 file changed, 5 insertions(+) >>>> >>> >>> [...] >>> >>> Reviewed-by: Nishanth Menon <nm@ti.com> >>> >> >> Are there any actions need to be done to have this patch merged? > > I would prefer if a platform maintainer (I assume Tony in this case) > picks it up and forwards it to soc@kernel.org together with other > related changes. Olof and I tend to ignore patches sent directly > to us, so we don't get in the way of platform maintainers that > may have already merged similar patches or have comments. > > I suspect Tony didn't pick it up either because from the patch > subject and the description, it is not clear that he is the one > to act on it. It helps to be more specific and ask the maintainer > by addressing them in person below the '---' line, as well as > only putting one person in 'To:' and the rest in 'Cc:'. Thanks for your comments and sorry that I disturbed you. But, honestly, I'm confused (and probably I'm not the first one) as multi_v7 is common for all ARM platforms while change is TI OMAP specific, and neither Documentation neither get_maintainer.pl provide any reliable information on how to proceed :( and who should be responsible for merging multi_x patches. I'd really have tried to do some checking while preparing patch and TO/CC list - some patches applied by platform maintainers, but some by top ARM maintainers. > > One comment on the contents of the patch: IIRC this is a fairly > large driver. To ensure we don't burden other users too much, > can you include the size of the vmlinux file before and after > this patch? before: text data bss dec hex filename 14703736 8024602 444976 23173314 16198c2 ./omap-arm/vmlinux after: text data bss dec hex filename 14727271 8029150 444528 23200949 16204b5 ./omap-arm/vmlinux diff: 27635 (dec)
On Fri, Oct 30, 2020 at 10:36 AM Grygorii Strashko <grygorii.strashko@ti.com> wrote: > On 29/10/2020 22:06, Arnd Bergmann wrote: > >> > >> Are there any actions need to be done to have this patch merged? > > > > I would prefer if a platform maintainer (I assume Tony in this case) > > picks it up and forwards it to soc@kernel.org together with other > > related changes. Olof and I tend to ignore patches sent directly > > to us, so we don't get in the way of platform maintainers that > > may have already merged similar patches or have comments. > > > > I suspect Tony didn't pick it up either because from the patch > > subject and the description, it is not clear that he is the one > > to act on it. It helps to be more specific and ask the maintainer > > by addressing them in person below the '---' line, as well as > > only putting one person in 'To:' and the rest in 'Cc:'. > > Thanks for your comments and sorry that I disturbed you. > > But, honestly, I'm confused (and probably I'm not the first one) as multi_v7 is common > for all ARM platforms while change is TI OMAP specific, > and neither Documentation neither get_maintainer.pl provide any reliable information > on how to proceed :( and who should be responsible for merging multi_x patches. > > I'd really have tried to do some checking while preparing patch and TO/CC list - > some patches applied by platform maintainers, but some by top ARM maintainers. I understand that this is confusion, and we should probably come up with a better way to handle it. To clarify further, while we prefer the patches to be picked up by the platform maintainers and forwarded to us for patches to the common files that are needed for a particular platform, you can also send these patches directly to soc@kernel.org, which puts them into patchwork at https://patchwork.kernel.org/project/linux-soc/list/. Once it's in there, we will process it by merging the patch or getting back to you for further clarification. > > One comment on the contents of the patch: IIRC this is a fairly > > large driver. To ensure we don't burden other users too much, > > can you include the size of the vmlinux file before and after > > this patch? > > before: > text data bss dec hex filename > 14703736 8024602 444976 23173314 16198c2 ./omap-arm/vmlinux > > after: > text data bss dec hex filename > 14727271 8029150 444528 23200949 16204b5 ./omap-arm/vmlinux > > diff: 27635 (dec) Ok, that doesn't look too bad, though the total size is definitely worrying. Please include the above in the changelog text. Arnd
diff --git a/arch/arm/configs/multi_v7_defconfig b/arch/arm/configs/multi_v7_defconfig index e9e76e32f10f..11b3184d8154 100644 --- a/arch/arm/configs/multi_v7_defconfig +++ b/arch/arm/configs/multi_v7_defconfig @@ -152,6 +152,7 @@ CONFIG_INET6_IPCOMP=m CONFIG_IPV6_MIP6=m CONFIG_IPV6_TUNNEL=m CONFIG_IPV6_MULTIPLE_TABLES=y +CONFIG_NET_SWITCHDEV=y CONFIG_NET_DSA=m CONFIG_CAN=y CONFIG_CAN_AT91=m @@ -268,9 +269,12 @@ CONFIG_SNI_AVE=y CONFIG_STMMAC_ETH=y CONFIG_DWMAC_DWC_QOS_ETH=y CONFIG_TI_CPSW=y +CONFIG_TI_CPSW_SWITCHDEV=y +CONFIG_TI_CPTS=y CONFIG_XILINX_EMACLITE=y CONFIG_BROADCOM_PHY=y CONFIG_ICPLUS_PHY=y +CONFIG_DP83867_PHY=y CONFIG_MARVELL_PHY=y CONFIG_MICREL_PHY=y CONFIG_AT803X_PHY=y @@ -434,6 +438,7 @@ CONFIG_SPI_TEGRA20_SLINK=y CONFIG_SPI_XILINX=y CONFIG_SPI_SPIDEV=y CONFIG_SPMI=y +CONFIG_PTP_1588_CLOCK=y CONFIG_PINCTRL_AS3722=y CONFIG_PINCTRL_RZA2=y CONFIG_PINCTRL_STMFX=y
Enable networking options required for NFS boot on TI platforms, which is widely for automated test systems. - enable new TI CPSW switch driver and related NET_SWITCHDEV config - enable TI DP83867 phy - explicitly enable PTP clock support to ensure dependent networking drivers will stay built-in Signed-off-by: Grygorii Strashko <grygorii.strashko@ti.com> --- arch/arm/configs/multi_v7_defconfig | 5 +++++ 1 file changed, 5 insertions(+)