| Message ID | 20200915145724.2065042-1-nikolay@cumulusnetworks.com |
|---|---|
| State | New |
| Headers | show |
| Series | [net-next] net: bridge: mcast: don't ignore return value of __grp_src_toex_excl | expand |
From: Nikolay Aleksandrov <nikolay@cumulusnetworks.com> Date: Tue, 15 Sep 2020 17:57:24 +0300 > When we're handling TO_EXCLUDE report in EXCLUDE filter mode we should > not ignore the return value of __grp_src_toex_excl() as we'll miss > sending notifications about group changes. > > Fixes: 5bf1e00b6849 ("net: bridge: mcast: support for IGMPV3/MLDv2 CHANGE_TO_INCLUDE/EXCLUDE report") > Signed-off-by: Nikolay Aleksandrov <nikolay@cumulusnetworks.com> Applied, thank you.
diff --git a/net/bridge/br_multicast.c b/net/bridge/br_multicast.c index 33adf44ef7ec..e77f1e27caf7 100644 --- a/net/bridge/br_multicast.c +++ b/net/bridge/br_multicast.c @@ -1710,7 +1710,7 @@ static bool br_multicast_toex(struct net_bridge_port_group *pg, changed = true; break; case MCAST_EXCLUDE: - __grp_src_toex_excl(pg, srcs, nsrcs, src_size); + changed = __grp_src_toex_excl(pg, srcs, nsrcs, src_size); break; }
When we're handling TO_EXCLUDE report in EXCLUDE filter mode we should not ignore the return value of __grp_src_toex_excl() as we'll miss sending notifications about group changes. Fixes: 5bf1e00b6849 ("net: bridge: mcast: support for IGMPV3/MLDv2 CHANGE_TO_INCLUDE/EXCLUDE report") Signed-off-by: Nikolay Aleksandrov <nikolay@cumulusnetworks.com> --- net/bridge/br_multicast.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)