| Message ID | 20200921114103.GA21071@duo.ucw.cz |
|---|---|
| State | New |
| Headers | show |
| Series | net/mlx5: remove unreachable return | expand |
On Mon, 2020-09-21 at 13:41 +0200, Pavel Machek wrote: > The last return statement is unreachable code. I'm not sure if it > will > provoke any warnings, but it looks ugly. > > Signed-off-by: Pavel Machek (CIP) <pavel@denx.de> > > Applied to net-next-mlx5. Thanks, Saeed.
On Mon, 2020-09-21 at 22:54 -0700, Saeed Mahameed wrote: > On Mon, 2020-09-21 at 13:41 +0200, Pavel Machek wrote: > > The last return statement is unreachable code. I'm not sure if it > > will > > provoke any warnings, but it looks ugly. > > > > Signed-off-by: Pavel Machek (CIP) <pavel@denx.de> > > > > > > Applied to net-next-mlx5. > > Thanks, > Saeed. > Actually checkpatch reports this issue: WARNING:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line by nominal patch author 'Pavel Machek <pavel@ucw.cz>' Do you want me to override the Signed-off-by tag with the above email ? Thanks, Saeed.
On Tue 2020-09-22 12:54:20, Saeed Mahameed wrote: > On Mon, 2020-09-21 at 22:54 -0700, Saeed Mahameed wrote: > > On Mon, 2020-09-21 at 13:41 +0200, Pavel Machek wrote: > > > The last return statement is unreachable code. I'm not sure if it > > > will > > > provoke any warnings, but it looks ugly. > > > > > > Signed-off-by: Pavel Machek (CIP) <pavel@denx.de> > > > > > > > > > > Applied to net-next-mlx5. > > > > Thanks, > > Saeed. > > > > Actually checkpatch reports this issue: > WARNING:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line by nominal > patch author 'Pavel Machek <pavel@ucw.cz>' > > Do you want me to override the Signed-off-by tag with the above email ? Sorry about that. Actually, overriding patch author to match signoff would be better (I should have sent it from: denx), but either way is okay with me. Best regards, Pavel -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
diff --git a/drivers/net/ethernet/mellanox/mlx5/core/lib/clock.c b/drivers/net/ethernet/mellanox/mlx5/core/lib/clock.c index 2d55b7c22c03..a804f92ccf23 100644 --- a/drivers/net/ethernet/mellanox/mlx5/core/lib/clock.c +++ b/drivers/net/ethernet/mellanox/mlx5/core/lib/clock.c @@ -431,8 +431,6 @@ static int mlx5_ptp_verify(struct ptp_clock_info *ptp, unsigned int pin, default: return -EOPNOTSUPP; } - - return -EOPNOTSUPP; } static const struct ptp_clock_info mlx5_ptp_clock_info = {
The last return statement is unreachable code. I'm not sure if it will provoke any warnings, but it looks ugly. Signed-off-by: Pavel Machek (CIP) <pavel@denx.de>