Message ID | 1394478649-9453-5-git-send-email-peter.maydell@linaro.org |
---|---|
State | Superseded |
Headers | show |
On Mon, Mar 10, 2014 at 07:10:40PM +0000, Peter Maydell wrote: > Add U suffix to avoid undefined behaviour. > > Signed-off-by: Peter Maydell <peter.maydell@linaro.org> Reviewed-by: Michael S. Tsirkin <mst@redhat.com> > --- > hw/i386/acpi-build.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/hw/i386/acpi-build.c b/hw/i386/acpi-build.c > index b1a7ebb..46d4e60 100644 > --- a/hw/i386/acpi-build.c > +++ b/hw/i386/acpi-build.c > @@ -813,7 +813,7 @@ static void build_pci_bus_end(PCIBus *bus, void *bus_state) > > build_append_byte(notify, 0x7B); /* AndOp */ > build_append_byte(notify, 0x68); /* Arg0Op */ > - build_append_int(notify, 0x1 << i); > + build_append_int(notify, 0x1U << i); > build_append_byte(notify, 0x00); /* NullName */ > build_append_byte(notify, 0x86); /* NotifyOp */ > build_append_nameseg(notify, "S%.02X_", PCI_DEVFN(i, 0)); > -- > 1.9.0 >
diff --git a/hw/i386/acpi-build.c b/hw/i386/acpi-build.c index b1a7ebb..46d4e60 100644 --- a/hw/i386/acpi-build.c +++ b/hw/i386/acpi-build.c @@ -813,7 +813,7 @@ static void build_pci_bus_end(PCIBus *bus, void *bus_state) build_append_byte(notify, 0x7B); /* AndOp */ build_append_byte(notify, 0x68); /* Arg0Op */ - build_append_int(notify, 0x1 << i); + build_append_int(notify, 0x1U << i); build_append_byte(notify, 0x00); /* NullName */ build_append_byte(notify, 0x86); /* NotifyOp */ build_append_nameseg(notify, "S%.02X_", PCI_DEVFN(i, 0));
Add U suffix to avoid undefined behaviour. Signed-off-by: Peter Maydell <peter.maydell@linaro.org> --- hw/i386/acpi-build.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)