| Message ID | 20200822144048.3961875-1-john@phrozen.org |
|---|---|
| State | New |
| Headers | show |
| Series | ath11k: dont enable bss color collision detection on non-transmitting BSS | expand |
John Crispin <john@phrozen.org> wrote: > A none transmitting BSS color collision detection should not be enabled. > > This patch depends on the BSS coloring and multiple bssid series. > > Signed-off-by: John Crispin <john@phrozen.org> Tested-on missing, on what hardware and firmware did you test this?
diff --git a/drivers/net/wireless/ath/ath11k/mac.c b/drivers/net/wireless/ath/ath11k/mac.c index 06cd61c5c681..c50e653df535 100644 --- a/drivers/net/wireless/ath/ath11k/mac.c +++ b/drivers/net/wireless/ath/ath11k/mac.c @@ -2119,7 +2119,8 @@ static void ath11k_mac_op_bss_info_changed(struct ieee80211_hw *hw, ret = ath11k_wmi_send_obss_color_collision_cfg_cmd( ar, arvif->vdev_id, info->he_bss_color.color, ATH11K_BSS_COLOR_COLLISION_DETECTION_AP_PERIOD_MS, - info->he_bss_color.enabled); + !arvif->vif->multiple_bssid.non_transmitted ? + info->he_bss_color.enabled : 0); if (ret) ath11k_warn(ar->ab, "failed to set bss color collision on vdev %i: %d\n", arvif->vdev_id, ret);
A none transmitting BSS color collision detection should not be enabled. This patch depends on the BSS coloring and multiple bssid series. Signed-off-by: John Crispin <john@phrozen.org> --- drivers/net/wireless/ath/ath11k/mac.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)