diff mbox series

[v2] ath11k: remove auto_start from channel config struct

Message ID 1601369799-22328-1-git-send-email-kvalo@codeaurora.org
State New
Headers show
Series [v2] ath11k: remove auto_start from channel config struct | expand

Commit Message

Kalle Valo Sept. 29, 2020, 8:56 a.m. UTC 
From: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>

Recent change in MHI bus removed the option to auto start the channels
during MHI driver probe. The channel will only be started when the MHI
client driver like QRTR gets probed. So, remove the option from ath11k
channel config struct.

Fixes: 1399fb87ea3e ("ath11k: register MHI controller device for QCA6390")
Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
---

v2

* cc also linux-wireless so that this goes to patchwork

 drivers/net/wireless/ath/ath11k/mhi.c | 4 ----
 1 file changed, 4 deletions(-)

Comments

Kalle Valo Oct. 1, 2020, 7:27 p.m. UTC | #1 
Kalle Valo <kvalo@codeaurora.org> wrote:

> Recent change in MHI bus removed the option to auto start the channels

> during MHI driver probe. The channel will only be started when the MHI

> client driver like QRTR gets probed. So, remove the option from ath11k

> channel config struct.

> 

> Fixes: 1399fb87ea3e ("ath11k: register MHI controller device for QCA6390")

> Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>

> Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>

> Signed-off-by: Kalle Valo <kvalo@codeaurora.org>


To avoid breaking ath11k we decided to postpone this change after the
merge window, it's a lot easier to deal at that time.

Patch set to Changes Requested.

-- 
https://patchwork.kernel.org/patch/11805307/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
diff mbox series

Patch

diff --git a/drivers/net/wireless/ath/ath11k/mhi.c b/drivers/net/wireless/ath/ath11k/mhi.c
index aded9a719d51..47a1ce1bee4f 100644
--- a/drivers/net/wireless/ath/ath11k/mhi.c
+++ b/drivers/net/wireless/ath/ath11k/mhi.c
@@ -24,7 +24,6 @@  static struct mhi_channel_config ath11k_mhi_channels[] = {
 		.offload_channel = false,
 		.doorbell_mode_switch = false,
 		.auto_queue = false,
-		.auto_start = false,
 	},
 	{
 		.num = 1,
@@ -39,7 +38,6 @@  static struct mhi_channel_config ath11k_mhi_channels[] = {
 		.offload_channel = false,
 		.doorbell_mode_switch = false,
 		.auto_queue = false,
-		.auto_start = false,
 	},
 	{
 		.num = 20,
@@ -54,7 +52,6 @@  static struct mhi_channel_config ath11k_mhi_channels[] = {
 		.offload_channel = false,
 		.doorbell_mode_switch = false,
 		.auto_queue = false,
-		.auto_start = true,
 	},
 	{
 		.num = 21,
@@ -69,7 +66,6 @@  static struct mhi_channel_config ath11k_mhi_channels[] = {
 		.offload_channel = false,
 		.doorbell_mode_switch = false,
 		.auto_queue = true,
-		.auto_start = true,
 	},
 };