| Message ID | 20201001152148.29747-3-l.stelmach@samsung.com |
|---|---|
| State | Superseded |
| Headers | show |
| Series | [v2,RESEND,1/9] spi: spi-s3c64xx: swap s3c64xx_spi_set_cs() and s3c64xx_enable_datapath() | expand |
On Thu, Oct 01, 2020 at 05:21:41PM +0200, Łukasz Stelmach wrote: > Fix issues with DMA transfers bigger than 512 bytes on Exynos3250. Without > the patches such transfers fail. > > The vendor kernel for ARTIK5 handles CS in a simmilar way. > > Signed-off-by: Łukasz Stelmach <l.stelmach@samsung.com> > Reviewed-by: Krzysztof Kozlowski <krzk@kernel.org> > --- > drivers/spi/spi-s3c64xx.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/spi/spi-s3c64xx.c b/drivers/spi/spi-s3c64xx.c > index 26c7cb79cd78..22bf8c75580a 100644 > --- a/drivers/spi/spi-s3c64xx.c > +++ b/drivers/spi/spi-s3c64xx.c > @@ -1379,6 +1379,7 @@ static struct s3c64xx_spi_port_config exynos4_spi_port_config = { > .tx_st_done = 25, > .high_speed = true, > .clk_from_cmu = true, > + .quirks = S3C64XX_SPI_QUIRK_CS_AUTO, I spotted now: you have here double space after '='. Best regards, Krzysztof
It was <2020-10-01 czw 21:04>, when Krzysztof Kozlowski wrote: > On Thu, Oct 01, 2020 at 05:21:41PM +0200, Łukasz Stelmach wrote: >> Fix issues with DMA transfers bigger than 512 bytes on Exynos3250. Without >> the patches such transfers fail. >> >> The vendor kernel for ARTIK5 handles CS in a simmilar way. >> >> Signed-off-by: Łukasz Stelmach <l.stelmach@samsung.com> >> Reviewed-by: Krzysztof Kozlowski <krzk@kernel.org> >> --- >> drivers/spi/spi-s3c64xx.c | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/drivers/spi/spi-s3c64xx.c b/drivers/spi/spi-s3c64xx.c >> index 26c7cb79cd78..22bf8c75580a 100644 >> --- a/drivers/spi/spi-s3c64xx.c >> +++ b/drivers/spi/spi-s3c64xx.c >> @@ -1379,6 +1379,7 @@ static struct s3c64xx_spi_port_config exynos4_spi_port_config = { >> .tx_st_done = 25, >> .high_speed = true, >> .clk_from_cmu = true, >> + .quirks = S3C64XX_SPI_QUIRK_CS_AUTO, > > I spotted now: you have here double space after '='. > Fixed, thanks. v3 is coming. -- Łukasz Stelmach Samsung R&D Institute Poland Samsung Electronics
diff --git a/drivers/spi/spi-s3c64xx.c b/drivers/spi/spi-s3c64xx.c index 26c7cb79cd78..22bf8c75580a 100644 --- a/drivers/spi/spi-s3c64xx.c +++ b/drivers/spi/spi-s3c64xx.c @@ -1379,6 +1379,7 @@ static struct s3c64xx_spi_port_config exynos4_spi_port_config = { .tx_st_done = 25, .high_speed = true, .clk_from_cmu = true, + .quirks = S3C64XX_SPI_QUIRK_CS_AUTO, }; static struct s3c64xx_spi_port_config exynos7_spi_port_config = {