| Message ID | 20200909084653.79341-1-jingxiangfeng@huawei.com |
|---|---|
| State | New |
| Headers | show |
| Series | scsi: esas2r: prevent a potential NULL dereference in esas2r_probe() | expand |
Jing, > esas2r_probe() calls scsi_host_put() in an error path. However, > esas2r_log_dev() may hit a potential NULL dereference. So use NUll instead. Wouldn't it be better to move the scsi_host_put() call after the error message?
On 2020/9/16 5:44, Martin K. Petersen wrote: > > Jing, > >> esas2r_probe() calls scsi_host_put() in an error path. However, >> esas2r_log_dev() may hit a potential NULL dereference. So use NUll instead. > > Wouldn't it be better to move the scsi_host_put() call after the error > message? There is already a message before the scsi_host_put() call. It is used to record calling function. >
On 2020/9/16 5:44, Martin K. Petersen wrote: > > Jing, > >> esas2r_probe() calls scsi_host_put() in an error path. However, >> esas2r_log_dev() may hit a potential NULL dereference. So use NUll instead. > > Wouldn't it be better to move the scsi_host_put() call after the error > message? There is already a message before the scsi_host_put() call. It is used to record calling function. >
diff --git a/drivers/scsi/esas2r/esas2r_main.c b/drivers/scsi/esas2r/esas2r_main.c index 7b49e2e9fcde..7d3fa9dac4ce 100644 --- a/drivers/scsi/esas2r/esas2r_main.c +++ b/drivers/scsi/esas2r/esas2r_main.c @@ -456,7 +456,7 @@ static int esas2r_probe(struct pci_dev *pcid, scsi_host_put(host); - esas2r_log_dev(ESAS2R_LOG_INFO, &(host->shost_gendev), + esas2r_log_dev(ESAS2R_LOG_INFO, NULL, "pci_set_drvdata(%p, NULL) called", pcid);
esas2r_probe() calls scsi_host_put() in an error path. However, esas2r_log_dev() may hit a potential NULL dereference. So use NUll instead. Signed-off-by: Jing Xiangfeng <jingxiangfeng@huawei.com> --- drivers/scsi/esas2r/esas2r_main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)