| Message ID | 20200829172532.29358-1-krzk@kernel.org |
|---|---|
| State | New |
| Headers | show |
| Series | [1/4] dt-bindings: display: samsung,amoled-mipi-dsi: Do not require enable-gpios on samsung,s6e63j0x03 | expand |
On Sat, Aug 29, 2020 at 07:25:29PM +0200, Krzysztof Kozlowski wrote: > The samsung,s6e63j0x03 does not have enable GPIO, so do not require it. > This fixes dtbs_check warning: > > arch/arm/boot/dts/exynos3250-rinato.dt.yaml: panel@0: 'enable-gpios' is a required property > > Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org> Acked-by: Sam Ravnborg <sam@ravnborg.org> I expect this patch is picked up with the dts fixes. Sam > --- > .../display/panel/samsung,amoled-mipi-dsi.yaml | 12 +++++++++++- > 1 file changed, 11 insertions(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/display/panel/samsung,amoled-mipi-dsi.yaml b/Documentation/devicetree/bindings/display/panel/samsung,amoled-mipi-dsi.yaml > index 96bdde9298e0..ccc482570d6a 100644 > --- a/Documentation/devicetree/bindings/display/panel/samsung,amoled-mipi-dsi.yaml > +++ b/Documentation/devicetree/bindings/display/panel/samsung,amoled-mipi-dsi.yaml > @@ -12,6 +12,17 @@ maintainers: > allOf: > - $ref: panel-common.yaml# > > + - if: > + properties: > + compatible: > + contains: > + enum: > + - samsung,s6e3ha2 > + - samsung,s6e3hf2 > + then: > + required: > + - enable-gpios > + > properties: > compatible: > enum: > @@ -39,7 +50,6 @@ required: > - vdd3-supply > - vci-supply > - reset-gpios > - - enable-gpios > > additionalProperties: false > > -- > 2.17.1
On 29.08.2020 19:25, Krzysztof Kozlowski wrote: > The fixed clocks are kept under dedicated node fixed-rate-clocks, thus a > fake "reg" was added. This is not correct with dtschema as fixed-clock > binding does not have a "reg" property: > > arch/arm/boot/dts/exynos3250-artik5-eval.dt.yaml: clock@0: 'reg' does not match any of the regexes: 'pinctrl-[0-9]+' > > Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org> Tested-by: Marek Szyprowski <m.szyprowski@samsung.com> > --- > arch/arm/boot/dts/exynos3250.dtsi | 42 +++++++++++++------------------ > 1 file changed, 17 insertions(+), 25 deletions(-) > > diff --git a/arch/arm/boot/dts/exynos3250.dtsi b/arch/arm/boot/dts/exynos3250.dtsi > index d3fb45a56527..c67c70e46794 100644 > --- a/arch/arm/boot/dts/exynos3250.dtsi > +++ b/arch/arm/boot/dts/exynos3250.dtsi > @@ -97,33 +97,25 @@ > }; > }; > > - fixed-rate-clocks { > - #address-cells = <1>; > - #size-cells = <0>; > - > - xusbxti: clock@0 { > - compatible = "fixed-clock"; > - reg = <0>; > - clock-frequency = <0>; > - #clock-cells = <0>; > - clock-output-names = "xusbxti"; > - }; > + xusbxti: clock-0 { > + compatible = "fixed-clock"; > + clock-frequency = <0>; > + #clock-cells = <0>; > + clock-output-names = "xusbxti"; > + }; > > - xxti: clock@1 { > - compatible = "fixed-clock"; > - reg = <1>; > - clock-frequency = <0>; > - #clock-cells = <0>; > - clock-output-names = "xxti"; > - }; > + xxti: clock-1 { > + compatible = "fixed-clock"; > + clock-frequency = <0>; > + #clock-cells = <0>; > + clock-output-names = "xxti"; > + }; > > - xtcxo: clock@2 { > - compatible = "fixed-clock"; > - reg = <2>; > - clock-frequency = <0>; > - #clock-cells = <0>; > - clock-output-names = "xtcxo"; > - }; > + xtcxo: clock-2 { > + compatible = "fixed-clock"; > + clock-frequency = <0>; > + #clock-cells = <0>; > + clock-output-names = "xtcxo"; > }; > > pmu { Best regards
On Sat, 29 Aug 2020 19:25:29 +0200, Krzysztof Kozlowski wrote: > The samsung,s6e63j0x03 does not have enable GPIO, so do not require it. > This fixes dtbs_check warning: > > arch/arm/boot/dts/exynos3250-rinato.dt.yaml: panel@0: 'enable-gpios' is a required property > > Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org> > --- > .../display/panel/samsung,amoled-mipi-dsi.yaml | 12 +++++++++++- > 1 file changed, 11 insertions(+), 1 deletion(-) > Applied, thanks!
diff --git a/Documentation/devicetree/bindings/display/panel/samsung,amoled-mipi-dsi.yaml b/Documentation/devicetree/bindings/display/panel/samsung,amoled-mipi-dsi.yaml index 96bdde9298e0..ccc482570d6a 100644 --- a/Documentation/devicetree/bindings/display/panel/samsung,amoled-mipi-dsi.yaml +++ b/Documentation/devicetree/bindings/display/panel/samsung,amoled-mipi-dsi.yaml @@ -12,6 +12,17 @@ maintainers: allOf: - $ref: panel-common.yaml# + - if: + properties: + compatible: + contains: + enum: + - samsung,s6e3ha2 + - samsung,s6e3hf2 + then: + required: + - enable-gpios + properties: compatible: enum: @@ -39,7 +50,6 @@ required: - vdd3-supply - vci-supply - reset-gpios - - enable-gpios additionalProperties: false
The samsung,s6e63j0x03 does not have enable GPIO, so do not require it. This fixes dtbs_check warning: arch/arm/boot/dts/exynos3250-rinato.dt.yaml: panel@0: 'enable-gpios' is a required property Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org> --- .../display/panel/samsung,amoled-mipi-dsi.yaml | 12 +++++++++++- 1 file changed, 11 insertions(+), 1 deletion(-)