| Message ID | 20200903181425.5015-3-krzk@kernel.org |
|---|---|
| State | New |
| Headers | show |
| Series | [v2,1/3] ARM: dts: exynos: Add assigned clock parent to CMU in Exynos3250 | expand |
On 9/3/20 20:14, Krzysztof Kozlowski wrote: > Commit 78a68acf3d33 ("ARM: dts: exynos: Switch to dedicated Odroid XU3 > sound card binding") added assigned clocks under sound device node. > > However the dtschema expects "clocks" property if "assigned-clocks" are > used. Add reference to input clock, the parent used in > "assigned-clock-parents" to silence the dtschema warnings: I'm afraid it doesn't improve anything, we just add another violation of the DT binding rules as the 'sound' node doesn't represent a real HW and shouldn't have 'clocks' property. Instead we could move the assigned-clock* properties to the I2S node, as in below patch. I have tested that already on xu3. ----------------------------------8<---------------------------
On Fri, Sep 04, 2020 at 12:20:36PM +0200, Sylwester Nawrocki wrote: > On 9/3/20 20:14, Krzysztof Kozlowski wrote: > > Commit 78a68acf3d33 ("ARM: dts: exynos: Switch to dedicated Odroid XU3 > > sound card binding") added assigned clocks under sound device node. > > > > However the dtschema expects "clocks" property if "assigned-clocks" are > > used. Add reference to input clock, the parent used in > > "assigned-clock-parents" to silence the dtschema warnings: > > I'm afraid it doesn't improve anything, we just add another violation of > the DT binding rules as the 'sound' node doesn't represent a real HW and > shouldn't have 'clocks' property. Instead we could move the assigned-clock* > properties to the I2S node, as in below patch. I have tested that already > on xu3. > > ----------------------------------8<--------------------------- > From f98d2f5ac86d1ae13a77ef481fcbf073a1740f26 Mon Sep 17 00:00:00 2001 > From: Sylwester Nawrocki <s.nawrocki@samsung.com> > Date: Fri, 4 Sep 2020 12:02:11 +0200 > Subject: [PATCH] ARM: dts: samsung: odroid-xu3: Move assigned-clock* > properties to i2s0 node > > The purpose of those assigned-clock-* properties is to configure clock for > for the I2S device so move them to respective node. > > This suppresses the dtbs_check warning: > arch/arm/boot/dts/exynos5422-odroidxu3.dt.yaml: sound: 'clocks' is a dependency > of 'assigned-clocks' Thanks, this is a good idea. Applied. Best regards, Krzysztof
diff --git a/arch/arm/boot/dts/exynos5422-odroidxu3-audio.dtsi b/arch/arm/boot/dts/exynos5422-odroidxu3-audio.dtsi index c3c2d85267da..44467a10c3b8 100644 --- a/arch/arm/boot/dts/exynos5422-odroidxu3-audio.dtsi +++ b/arch/arm/boot/dts/exynos5422-odroidxu3-audio.dtsi @@ -29,6 +29,11 @@ "HiFi Playback", "Mixer DAI TX", "Mixer DAI RX", "HiFi Capture"; + clocks = <&clock CLK_FOUT_EPLL>, + <&clock CLK_MOUT_EPLL>, + <&clock CLK_MOUT_MAU_EPLL>, + <&clock CLK_MAU_EPLL>, + <&clock_audss EXYNOS_MOUT_AUDSS>; assigned-clocks = <&clock CLK_MOUT_EPLL>, <&clock CLK_MOUT_MAU_EPLL>, <&clock CLK_MOUT_USER_MAU_EPLL>,
Commit 78a68acf3d33 ("ARM: dts: exynos: Switch to dedicated Odroid XU3 sound card binding") added assigned clocks under sound device node. However the dtschema expects "clocks" property if "assigned-clocks" are used. Add reference to input clock, the parent used in "assigned-clock-parents" to silence the dtschema warnings: arch/arm/boot/dts/exynos5422-odroidxu3.dt.yaml: sound: 'clocks' is a dependency of 'assigned-clocks' Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org> --- arch/arm/boot/dts/exynos5422-odroidxu3-audio.dtsi | 5 +++++ 1 file changed, 5 insertions(+)