| Message ID | 20200906142146.21266-1-krzk@kernel.org |
|---|---|
| State | New |
| Headers | show |
| Series | [v3,1/3] ARM: dts: exynos: Add assigned clock parent to CMU in Exynos3250 | expand |
On Sun, Sep 06, 2020 at 04:21:44PM +0200, Krzysztof Kozlowski wrote: > Commit 52005dece527 ("ARM: dts: Add assigned clock parents to CMU node > for exynos3250") added assigned clocks under Clock Management Unit to > fix hangs when accessing ISP registers. > > However the dtschema expects "clocks" property if "assigned-clocks" are > used. Add reference to input clock, the parent used in > "assigned-clock-parents" to silence the dtschema warnings: > > arch/arm/boot/dts/exynos3250-artik5-eval.dt.yaml: clock-controller@10030000: 'clocks' is a dependency of 'assigned-clocks' > > Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org> > > --- > > Changes since v2: > 1. Use XUSBXTI as real input clock. > > Changes since v1: > 1. Add clocks property. > > This is a v2 for: > https://lore.kernel.org/linux-samsung-soc/20200901101534.GE23793@kozik-lap/T/#me85ac382b847dadbc3f6ebf30e94e70b5df1ebb6 > --- > arch/arm/boot/dts/exynos3250-artik5.dtsi | 4 ++++ > arch/arm/boot/dts/exynos3250-monk.dts | 4 ++++ > arch/arm/boot/dts/exynos3250-rinato.dts | 4 ++++ Applied. Best regards, Krzysztof
Hi Krzysztof, On 11.09.2020 16:54, Krzysztof Kozlowski wrote: > On Sun, Sep 06, 2020 at 04:21:45PM +0200, Krzysztof Kozlowski wrote: >> Commit 68605101460e ("ARM: dts: exynos: Add support for audio over HDMI >> for Odroid X/X2/U3") added assigned clocks under Clock Management Unit. >> >> However the dtschema expects "clocks" property if "assigned-clocks" are >> used. Add reference to input clock, the parent used in >> "assigned-clock-parents" to silence the dtschema warnings: >> >> arch/arm/boot/dts/exynos4412-odroidu3.dt.yaml: clock-controller@10030000: 'clocks' is a dependency of 'assigned-clocks' >> > Applied. This patch breaks operation of clocks on Odroid X2/U3: # dmesg | grep clk [ 0.000000] exynos_clkout_init: failed to register clkout clock [ 0.000000] Exynos4x12 clocks: sclk_apll = 1000000000, sclk_mpll = 800000000 sclk_epll = 45158401, sclk_vpll = 350000000, arm_clk = 1000000000 [ 2.569484] usb3503 0-0008: unable to request refclk (-517) [ 2.848718] s3c-sdhci 12530000.sdhci: clock source 2: mmc_busclk.2 (50000000 Hz) [ 3.373850] usb3503 0-0008: unable to request refclk (-517) [ 3.542777] usb3503 0-0008: unable to request refclk (-517) [ 3.544005] usb3503 0-0008: unable to request refclk (-517) [ 3.559223] usb3503 0-0008: unable to request refclk (-517) Please revert or drop if possible. Best regards
diff --git a/arch/arm/boot/dts/exynos3250-artik5.dtsi b/arch/arm/boot/dts/exynos3250-artik5.dtsi index 6c2f320be2f4..12887b3924af 100644 --- a/arch/arm/boot/dts/exynos3250-artik5.dtsi +++ b/arch/arm/boot/dts/exynos3250-artik5.dtsi @@ -55,6 +55,10 @@ assigned-clock-rates = <6000000>; }; +&cmu { + clocks = <&xusbxti>; +}; + &cpu0 { cpu0-supply = <&buck2_reg>; }; diff --git a/arch/arm/boot/dts/exynos3250-monk.dts b/arch/arm/boot/dts/exynos3250-monk.dts index 9d77a73bc92b..c1a68e612037 100644 --- a/arch/arm/boot/dts/exynos3250-monk.dts +++ b/arch/arm/boot/dts/exynos3250-monk.dts @@ -164,6 +164,10 @@ status = "okay"; }; +&cmu { + clocks = <&xusbxti>; +}; + &cpu0 { cpu0-supply = <&buck2_reg>; }; diff --git a/arch/arm/boot/dts/exynos3250-rinato.dts b/arch/arm/boot/dts/exynos3250-rinato.dts index 3df003af0d15..b55afaaa691e 100644 --- a/arch/arm/boot/dts/exynos3250-rinato.dts +++ b/arch/arm/boot/dts/exynos3250-rinato.dts @@ -205,6 +205,10 @@ status = "okay"; }; +&cmu { + clocks = <&xusbxti>; +}; + &cpu0 { cpu0-supply = <&buck2_reg>; };
Commit 52005dece527 ("ARM: dts: Add assigned clock parents to CMU node for exynos3250") added assigned clocks under Clock Management Unit to fix hangs when accessing ISP registers. However the dtschema expects "clocks" property if "assigned-clocks" are used. Add reference to input clock, the parent used in "assigned-clock-parents" to silence the dtschema warnings: arch/arm/boot/dts/exynos3250-artik5-eval.dt.yaml: clock-controller@10030000: 'clocks' is a dependency of 'assigned-clocks' Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org> --- Changes since v2: 1. Use XUSBXTI as real input clock. Changes since v1: 1. Add clocks property. This is a v2 for: https://lore.kernel.org/linux-samsung-soc/20200901101534.GE23793@kozik-lap/T/#me85ac382b847dadbc3f6ebf30e94e70b5df1ebb6 --- arch/arm/boot/dts/exynos3250-artik5.dtsi | 4 ++++ arch/arm/boot/dts/exynos3250-monk.dts | 4 ++++ arch/arm/boot/dts/exynos3250-rinato.dts | 4 ++++ 3 files changed, 12 insertions(+)