diff mbox series

[v3,1/5] arch_topology: validate input frequencies to arch_set_freq_scale()

Message ID 20200824210252.27486-2-ionela.voinescu@arm.com
State Accepted
Commit 0a10d3fe3e5c601031676e81b41fb2977650b4d4
Headers show
Series [v3,1/5] arch_topology: validate input frequencies to arch_set_freq_scale() | expand

Commit Message

Ionela Voinescu Aug. 24, 2020, 9:02 p.m. UTC
The current frequency passed to arch_set_freq_scale() could end up
being 0, signaling an error in setting a new frequency. Also, if the
maximum frequency in 0, this will result in a division by 0 error.

Therefore, validate these input values before using them for the
setting of the frequency scale factor.

Signed-off-by: Ionela Voinescu <ionela.voinescu@arm.com>
Cc: Sudeep Holla <sudeep.holla@arm.com>
Cc: Rafael J. Wysocki <rjw@rjwysocki.net>
---
 drivers/base/arch_topology.c | 3 +++
 1 file changed, 3 insertions(+)
diff mbox series

Patch

diff --git a/drivers/base/arch_topology.c b/drivers/base/arch_topology.c
index 75f72d684294..1aca82fcceb8 100644
--- a/drivers/base/arch_topology.c
+++ b/drivers/base/arch_topology.c
@@ -33,6 +33,9 @@  void arch_set_freq_scale(struct cpumask *cpus, unsigned long cur_freq,
 	unsigned long scale;
 	int i;
 
+	if (!cur_freq || !max_freq)
+		return;
+
 	/*
 	 * If the use of counters for FIE is enabled, just return as we don't
 	 * want to update the scale factor with information from CPUFREQ.