diff mbox series

dt-bindings: power: Correct interrupt flags in examples

Message ID 20200908145922.4502-1-krzk@kernel.org
State Accepted
Commit 488e5947d975e161ff51407538248d42ef0011d1
Headers show
Series dt-bindings: power: Correct interrupt flags in examples | expand

Commit Message

Krzysztof Kozlowski Sept. 8, 2020, 2:59 p.m. UTC
GPIO_ACTIVE_x flags are not correct in the context of interrupt flags.
These are simple defines so they could be used in DTS but they will not
have the same meaning:
1. GPIO_ACTIVE_HIGH = 0 = IRQ_TYPE_NONE
2. GPIO_ACTIVE_LOW  = 1 = IRQ_TYPE_EDGE_RISING

Correct the interrupt flags, assuming the author of the code wanted some
logical behavior behind the name "ACTIVE_xxx", this is:
  ACTIVE_LOW => IRQ_TYPE_LEVEL_LOW

Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
---
 .../devicetree/bindings/power/supply/act8945a-charger.txt       | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Rob Herring (Arm) Sept. 15, 2020, 4:54 p.m. UTC | #1
On Tue, 08 Sep 2020 16:59:22 +0200, Krzysztof Kozlowski wrote:
> GPIO_ACTIVE_x flags are not correct in the context of interrupt flags.

> These are simple defines so they could be used in DTS but they will not

> have the same meaning:

> 1. GPIO_ACTIVE_HIGH = 0 = IRQ_TYPE_NONE

> 2. GPIO_ACTIVE_LOW  = 1 = IRQ_TYPE_EDGE_RISING

> 

> Correct the interrupt flags, assuming the author of the code wanted some

> logical behavior behind the name "ACTIVE_xxx", this is:

>   ACTIVE_LOW => IRQ_TYPE_LEVEL_LOW

> 

> Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>

> ---

>  .../devicetree/bindings/power/supply/act8945a-charger.txt       | 2 +-

>  1 file changed, 1 insertion(+), 1 deletion(-)

> 


Applied, thanks!
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/power/supply/act8945a-charger.txt b/Documentation/devicetree/bindings/power/supply/act8945a-charger.txt
index c7dfb7cecf40..cb737a9e1f16 100644
--- a/Documentation/devicetree/bindings/power/supply/act8945a-charger.txt
+++ b/Documentation/devicetree/bindings/power/supply/act8945a-charger.txt
@@ -33,7 +33,7 @@  Example:
 			pinctrl-names = "default";
 			pinctrl-0 = <&pinctrl_charger_chglev &pinctrl_charger_lbo &pinctrl_charger_irq>;
 			interrupt-parent = <&pioA>;
-			interrupts = <45 GPIO_ACTIVE_LOW>;
+			interrupts = <45 IRQ_TYPE_LEVEL_LOW>;
 
 			active-semi,chglev-gpios = <&pioA 12 GPIO_ACTIVE_HIGH>;
 			active-semi,lbo-gpios = <&pioA 72 GPIO_ACTIVE_LOW>;