diff mbox series

[v5] dt-bindings: media: imx274: Convert to json-schema

Message ID 20200910162009.613976-1-jacopo+renesas@jmondi.org
State Superseded
Headers show
Series [v5] dt-bindings: media: imx274: Convert to json-schema | expand

Commit Message

Jacopo Mondi Sept. 10, 2020, 4:20 p.m. UTC
Convert the imx274 bindings document to json-schema and update
the MAINTAINERS file accordingly.

Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Signed-off-by: Jacopo Mondi <jacopo+renesas@jmondi.org>
---

v4->v5:
- Add optional properties that were upstreamed in v5.9-rc2 in the textual
  bindings
- Move them to be lowercase: this patch should be fast-tracked through the
  fixes branch to make sure it gets in before v5.9 is released, otherwise the
  textual bindings will have supplies names in uppercase

---
 .../devicetree/bindings/media/i2c/imx274.txt  | 38 ---------
 .../bindings/media/i2c/sony,imx274.yaml       | 77 +++++++++++++++++++
 MAINTAINERS                                   |  2 +-
 3 files changed, 78 insertions(+), 39 deletions(-)
 delete mode 100644 Documentation/devicetree/bindings/media/i2c/imx274.txt
 create mode 100644 Documentation/devicetree/bindings/media/i2c/sony,imx274.yaml

--
2.28.0

Comments

Jacopo Mondi Sept. 11, 2020, 8:59 a.m. UTC | #1
Hi Luca,

On Fri, Sep 11, 2020 at 09:53:23AM +0200, Luca Ceresoli wrote:
> Hi Jacopo,
>
> On 10/09/20 18:20, Jacopo Mondi wrote:
> > Convert the imx274 bindings document to json-schema and update
> > the MAINTAINERS file accordingly.
> >
> > Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> > Signed-off-by: Jacopo Mondi <jacopo+renesas@jmondi.org>
> > ---
> >
> > v4->v5:
> > - Add optional properties that were upstreamed in v5.9-rc2 in the textual
> >   bindings
> > - Move them to be lowercase: this patch should be fast-tracked through the
> >   fixes branch to make sure it gets in before v5.9 is released, otherwise the
> >   textual bindings will have supplies names in uppercase
> >
> > ---
> >  .../devicetree/bindings/media/i2c/imx274.txt  | 38 ---------
> >  .../bindings/media/i2c/sony,imx274.yaml       | 77 +++++++++++++++++++
> >  MAINTAINERS                                   |  2 +-
> >  3 files changed, 78 insertions(+), 39 deletions(-)
> >  delete mode 100644 Documentation/devicetree/bindings/media/i2c/imx274.txt
> >  create mode 100644 Documentation/devicetree/bindings/media/i2c/sony,imx274.yaml
> >
> > diff --git a/Documentation/devicetree/bindings/media/i2c/imx274.txt b/Documentation/devicetree/bindings/media/i2c/imx274.txt
> > deleted file mode 100644
> > index 0727079d2410..000000000000
> > --- a/Documentation/devicetree/bindings/media/i2c/imx274.txt
> > +++ /dev/null
> > @@ -1,38 +0,0 @@
> > -* Sony 1/2.5-Inch 8.51Mp CMOS Digital Image Sensor
> > -
> > -The Sony imx274 is a 1/2.5-inch CMOS active pixel digital image sensor with
> > -an active array size of 3864H x 2202V. It is programmable through I2C
> > -interface. The I2C address is fixed to 0x1a as per sensor data sheet.
> > -Image data is sent through MIPI CSI-2, which is configured as 4 lanes
> > -at 1440 Mbps.
> > -
> > -
> > -Required Properties:
> > -- compatible: value should be "sony,imx274" for imx274 sensor
> > -- reg: I2C bus address of the device
> > -
> > -Optional Properties:
> > -- reset-gpios: Sensor reset GPIO
> > -- clocks: Reference to the input clock.
> > -- clock-names: Should be "inck".
> > -- VANA-supply: Sensor 2.8v analog supply.
> > -- VDIG-supply: Sensor 1.8v digital core supply.
> > -- VDDL-supply: Sensor digital IO 1.2v supply.
> > -
> > -The imx274 device node should contain one 'port' child node with
> > -an 'endpoint' subnode. For further reading on port node refer to
> > -Documentation/devicetree/bindings/media/video-interfaces.txt.
> > -
> > -Example:
> > -	sensor@1a {
> > -		compatible = "sony,imx274";
> > -		reg = <0x1a>;
> > -		#address-cells = <1>;
> > -		#size-cells = <0>;
> > -		reset-gpios = <&gpio_sensor 0 0>;
> > -		port {
> > -			sensor_out: endpoint {
> > -				remote-endpoint = <&csiss_in>;
> > -			};
> > -		};
> > -	};
> > diff --git a/Documentation/devicetree/bindings/media/i2c/sony,imx274.yaml b/Documentation/devicetree/bindings/media/i2c/sony,imx274.yaml
> > new file mode 100644
> > index 000000000000..fe81def68466
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/media/i2c/sony,imx274.yaml
> > @@ -0,0 +1,77 @@
> > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> > +%YAML 1.2
> > +---
> > +$id: http://devicetree.org/schemas/media/i2c/sony,imx274.yaml#
> > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > +
> > +title: Sony 1/2.5-Inch 8.51MP CMOS Digital Image Sensor
> > +
> > +maintainers:
> > +  - Leon Luo <leonl@leopardimaging.com>
> > +
> > +description: |
> > +  The Sony IMX274 is a 1/2.5-inch CMOS active pixel digital image sensor with an
> > +  active array size of 3864H x 2202V. It is programmable through I2C interface.
> > +  Image data is sent through MIPI CSI-2, which is configured as 4 lanes at 1440
> > +  Mbps.
> > +
> > +properties:
> > +  compatible:
> > +    const: sony,imx274
> > +
> > +  reg:
> > +    const: 0x1a
> > +
> > +  reset-gpios:
> > +    maxItems: 1
> > +
> > +  port:
> > +    type: object
> > +    description: |
> > +      Output video port. See ../video-interfaces.txt.
> > +
> > +  clocks:
> > +    maxItems: 1
> > +
> > +  clock-names:
> > +    const: inck
> > +
> > +  vana-supply:
> > +    description: Sensor 2.8v analog supply.
> > +    maxItems: 1
> > +
> > +  vdig-supply:
> > +    description: Sensor 2.8v analog supply.
>
> Copy-paste leftover. Should be "Sensor 1.8v digital core supply."
>

oooo :(
I've been so sloppy on this series I'm almost ashamed.

I'll send a v6 with your tag in

> > +    maxItems: 1
> > +
> > +  vddl-supply:
> > +    description: Sensor 2.8v analog supply.
>
> Same here, should be "Sensor digital IO 1.2v supply."
>
> With the above fixed you can add to v6:
>  Reviewed-by: Luca Ceresoli <luca@lucaceresoli.net>
>
> --
> Luca
Sakari Ailus Sept. 11, 2020, 10:15 p.m. UTC | #2
On Fri, Sep 11, 2020 at 08:35:50PM +0300, Laurent Pinchart wrote:
> Hi Jacopo,
> 
> On Fri, Sep 11, 2020 at 10:59:39AM +0200, Jacopo Mondi wrote:
> > On Fri, Sep 11, 2020 at 09:53:23AM +0200, Luca Ceresoli wrote:
> > > On 10/09/20 18:20, Jacopo Mondi wrote:
> > > > Convert the imx274 bindings document to json-schema and update
> > > > the MAINTAINERS file accordingly.
> > > >
> > > > Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> > > > Signed-off-by: Jacopo Mondi <jacopo+renesas@jmondi.org>
> > > > ---
> > > >
> > > > v4->v5:
> > > > - Add optional properties that were upstreamed in v5.9-rc2 in the textual
> > > >   bindings
> > > > - Move them to be lowercase: this patch should be fast-tracked through the
> > > >   fixes branch to make sure it gets in before v5.9 is released, otherwise the
> > > >   textual bindings will have supplies names in uppercase
> > > >
> > > > ---
> > > >  .../devicetree/bindings/media/i2c/imx274.txt  | 38 ---------
> > > >  .../bindings/media/i2c/sony,imx274.yaml       | 77 +++++++++++++++++++
> > > >  MAINTAINERS                                   |  2 +-
> > > >  3 files changed, 78 insertions(+), 39 deletions(-)
> > > >  delete mode 100644 Documentation/devicetree/bindings/media/i2c/imx274.txt
> > > >  create mode 100644 Documentation/devicetree/bindings/media/i2c/sony,imx274.yaml
> > > >
> > > > diff --git a/Documentation/devicetree/bindings/media/i2c/imx274.txt b/Documentation/devicetree/bindings/media/i2c/imx274.txt
> > > > deleted file mode 100644
> > > > index 0727079d2410..000000000000
> > > > --- a/Documentation/devicetree/bindings/media/i2c/imx274.txt
> > > > +++ /dev/null
> > > > @@ -1,38 +0,0 @@
> > > > -* Sony 1/2.5-Inch 8.51Mp CMOS Digital Image Sensor
> > > > -
> > > > -The Sony imx274 is a 1/2.5-inch CMOS active pixel digital image sensor with
> > > > -an active array size of 3864H x 2202V. It is programmable through I2C
> > > > -interface. The I2C address is fixed to 0x1a as per sensor data sheet.
> > > > -Image data is sent through MIPI CSI-2, which is configured as 4 lanes
> > > > -at 1440 Mbps.
> > > > -
> > > > -
> > > > -Required Properties:
> > > > -- compatible: value should be "sony,imx274" for imx274 sensor
> > > > -- reg: I2C bus address of the device
> > > > -
> > > > -Optional Properties:
> > > > -- reset-gpios: Sensor reset GPIO
> > > > -- clocks: Reference to the input clock.
> > > > -- clock-names: Should be "inck".
> > > > -- VANA-supply: Sensor 2.8v analog supply.
> > > > -- VDIG-supply: Sensor 1.8v digital core supply.
> > > > -- VDDL-supply: Sensor digital IO 1.2v supply.
> > > > -
> > > > -The imx274 device node should contain one 'port' child node with
> > > > -an 'endpoint' subnode. For further reading on port node refer to
> > > > -Documentation/devicetree/bindings/media/video-interfaces.txt.
> > > > -
> > > > -Example:
> > > > -	sensor@1a {
> > > > -		compatible = "sony,imx274";
> > > > -		reg = <0x1a>;
> > > > -		#address-cells = <1>;
> > > > -		#size-cells = <0>;
> > > > -		reset-gpios = <&gpio_sensor 0 0>;
> > > > -		port {
> > > > -			sensor_out: endpoint {
> > > > -				remote-endpoint = <&csiss_in>;
> > > > -			};
> > > > -		};
> > > > -	};
> > > > diff --git a/Documentation/devicetree/bindings/media/i2c/sony,imx274.yaml b/Documentation/devicetree/bindings/media/i2c/sony,imx274.yaml
> > > > new file mode 100644
> > > > index 000000000000..fe81def68466
> > > > --- /dev/null
> > > > +++ b/Documentation/devicetree/bindings/media/i2c/sony,imx274.yaml
> > > > @@ -0,0 +1,77 @@
> > > > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> > > > +%YAML 1.2
> > > > +---
> > > > +$id: http://devicetree.org/schemas/media/i2c/sony,imx274.yaml#
> > > > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > > > +
> > > > +title: Sony 1/2.5-Inch 8.51MP CMOS Digital Image Sensor
> > > > +
> > > > +maintainers:
> > > > +  - Leon Luo <leonl@leopardimaging.com>
> > > > +
> > > > +description: |
> > > > +  The Sony IMX274 is a 1/2.5-inch CMOS active pixel digital image sensor with an
> > > > +  active array size of 3864H x 2202V. It is programmable through I2C interface.
> > > > +  Image data is sent through MIPI CSI-2, which is configured as 4 lanes at 1440
> > > > +  Mbps.
> > > > +
> > > > +properties:
> > > > +  compatible:
> > > > +    const: sony,imx274
> > > > +
> > > > +  reg:
> > > > +    const: 0x1a
> > > > +
> > > > +  reset-gpios:
> > > > +    maxItems: 1
> > > > +
> > > > +  port:
> > > > +    type: object
> > > > +    description: |
> > > > +      Output video port. See ../video-interfaces.txt.
> > > > +
> > > > +  clocks:
> > > > +    maxItems: 1
> > > > +
> > > > +  clock-names:
> > > > +    const: inck
> > > > +
> > > > +  vana-supply:
> > > > +    description: Sensor 2.8v analog supply.
> > > > +    maxItems: 1
> > > > +
> > > > +  vdig-supply:
> > > > +    description: Sensor 2.8v analog supply.
> > >
> > > Copy-paste leftover. Should be "Sensor 1.8v digital core supply."
> > 
> > oooo :(
> > I've been so sloppy on this series I'm almost ashamed.
> > 
> > I'll send a v6 with your tag in
> 
> And if you haven't already, s/v/V/ (the voltage symbol is an uppercase
> V).

Also a whitespace character before that "V" would be nice. :)
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/media/i2c/imx274.txt b/Documentation/devicetree/bindings/media/i2c/imx274.txt
deleted file mode 100644
index 0727079d2410..000000000000
--- a/Documentation/devicetree/bindings/media/i2c/imx274.txt
+++ /dev/null
@@ -1,38 +0,0 @@ 
-* Sony 1/2.5-Inch 8.51Mp CMOS Digital Image Sensor
-
-The Sony imx274 is a 1/2.5-inch CMOS active pixel digital image sensor with
-an active array size of 3864H x 2202V. It is programmable through I2C
-interface. The I2C address is fixed to 0x1a as per sensor data sheet.
-Image data is sent through MIPI CSI-2, which is configured as 4 lanes
-at 1440 Mbps.
-
-
-Required Properties:
-- compatible: value should be "sony,imx274" for imx274 sensor
-- reg: I2C bus address of the device
-
-Optional Properties:
-- reset-gpios: Sensor reset GPIO
-- clocks: Reference to the input clock.
-- clock-names: Should be "inck".
-- VANA-supply: Sensor 2.8v analog supply.
-- VDIG-supply: Sensor 1.8v digital core supply.
-- VDDL-supply: Sensor digital IO 1.2v supply.
-
-The imx274 device node should contain one 'port' child node with
-an 'endpoint' subnode. For further reading on port node refer to
-Documentation/devicetree/bindings/media/video-interfaces.txt.
-
-Example:
-	sensor@1a {
-		compatible = "sony,imx274";
-		reg = <0x1a>;
-		#address-cells = <1>;
-		#size-cells = <0>;
-		reset-gpios = <&gpio_sensor 0 0>;
-		port {
-			sensor_out: endpoint {
-				remote-endpoint = <&csiss_in>;
-			};
-		};
-	};
diff --git a/Documentation/devicetree/bindings/media/i2c/sony,imx274.yaml b/Documentation/devicetree/bindings/media/i2c/sony,imx274.yaml
new file mode 100644
index 000000000000..fe81def68466
--- /dev/null
+++ b/Documentation/devicetree/bindings/media/i2c/sony,imx274.yaml
@@ -0,0 +1,77 @@ 
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/media/i2c/sony,imx274.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Sony 1/2.5-Inch 8.51MP CMOS Digital Image Sensor
+
+maintainers:
+  - Leon Luo <leonl@leopardimaging.com>
+
+description: |
+  The Sony IMX274 is a 1/2.5-inch CMOS active pixel digital image sensor with an
+  active array size of 3864H x 2202V. It is programmable through I2C interface.
+  Image data is sent through MIPI CSI-2, which is configured as 4 lanes at 1440
+  Mbps.
+
+properties:
+  compatible:
+    const: sony,imx274
+
+  reg:
+    const: 0x1a
+
+  reset-gpios:
+    maxItems: 1
+
+  port:
+    type: object
+    description: |
+      Output video port. See ../video-interfaces.txt.
+
+  clocks:
+    maxItems: 1
+
+  clock-names:
+    const: inck
+
+  vana-supply:
+    description: Sensor 2.8v analog supply.
+    maxItems: 1
+
+  vdig-supply:
+    description: Sensor 2.8v analog supply.
+    maxItems: 1
+
+  vddl-supply:
+    description: Sensor 2.8v analog supply.
+    maxItems: 1
+
+required:
+  - compatible
+  - reg
+  - port
+
+additionalProperties: false
+
+examples:
+  - |
+    i2c0 {
+        #address-cells = <1>;
+        #size-cells = <0>;
+
+        imx274: camera-sensor@1a {
+            compatible = "sony,imx274";
+            reg = <0x1a>;
+            reset-gpios = <&gpio_sensor 0 0>;
+
+            port {
+                sensor_out: endpoint {
+                    remote-endpoint = <&csiss_in>;
+                };
+            };
+        };
+    };
+
+...
diff --git a/MAINTAINERS b/MAINTAINERS
index 355f9c04b56b..2c9393a7e1ba 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -16150,7 +16150,7 @@  M:	Leon Luo <leonl@leopardimaging.com>
 L:	linux-media@vger.kernel.org
 S:	Maintained
 T:	git git://linuxtv.org/media_tree.git
-F:	Documentation/devicetree/bindings/media/i2c/imx274.txt
+F:	Documentation/devicetree/bindings/media/i2c/sony,imx274.yaml
 F:	drivers/media/i2c/imx274.c

 SONY IMX290 SENSOR DRIVER