diff mbox series

i2c: nvidia-gpu: use dev_info for timeout error

Message ID 20200921173426.2636-1-ajayg@nvidia.com
State New
Headers show
Series i2c: nvidia-gpu: use dev_info for timeout error | expand

Commit Message

Ajay Gupta Sept. 21, 2020, 5:34 p.m. UTC 
From: Ajay Gupta <ajayg@nvidia.com>

Timeout error may be seen due to missing i2c client such as
USB Type-C UCSI controller on some NVIDIA GPU card. Currently
we don't have a correct way to identify these cards.

Tools like Plymouth (splashscreen) doesn't like dev_err so
changing timeout status log to dev_info.

Bug information:
https://bugzilla.kernel.org/show_bug.cgi?id=206653

Signed-off-by: Ajay Gupta <ajayg@nvidia.com>
---
 drivers/i2c/busses/i2c-nvidia-gpu.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Wolfram Sang Sept. 21, 2020, 6:08 p.m. UTC | #1 
On Mon, Sep 21, 2020 at 10:34:26AM -0700, Ajay Gupta wrote:
> From: Ajay Gupta <ajayg@nvidia.com>

> 

> Timeout error may be seen due to missing i2c client such as

> USB Type-C UCSI controller on some NVIDIA GPU card. Currently

> we don't have a correct way to identify these cards.

> 

> Tools like Plymouth (splashscreen) doesn't like dev_err so

> changing timeout status log to dev_info.

> 

> Bug information:

> https://bugzilla.kernel.org/show_bug.cgi?id=206653

> 

> Signed-off-by: Ajay Gupta <ajayg@nvidia.com>


Hmm, a KERN_INFO message saying "error" does not make much sense. Maybe
this is an argument to simply remove the message?
Ajay Gupta Sept. 21, 2020, 7:36 p.m. UTC | #2 
Hi Wolfram,

> -----Original Message-----

> From: Wolfram Sang <wsa@the-dreams.de>

> Sent: Monday, September 21, 2020 11:09 AM

> To: Ajay Gupta <ajaykuee@gmail.com>

> Cc: linux-i2c@vger.kernel.org; Ajay Gupta <ajayg@nvidia.com>

> Subject: Re: [PATCH] i2c: nvidia-gpu: use dev_info for timeout error

> 

> On Mon, Sep 21, 2020 at 10:34:26AM -0700, Ajay Gupta wrote:

> > From: Ajay Gupta <ajayg@nvidia.com>

> >

> > Timeout error may be seen due to missing i2c client such as USB Type-C

> > UCSI controller on some NVIDIA GPU card. Currently we don't have a

> > correct way to identify these cards.

> >

> > Tools like Plymouth (splashscreen) doesn't like dev_err so changing

> > timeout status log to dev_info.

> >

> > Bug information:

> > https://bugzilla.kernel.org/show_bug.cgi?id=206653

> >

> > Signed-off-by: Ajay Gupta <ajayg@nvidia.com>

> 

> Hmm, a KERN_INFO message saying "error" does not make much sense.

> Maybe this is an argument to simply remove the message?

Sounds good. Client driver anyways gets probe error in case of a real i2c
timeout with an existing i2c device and that can help debug.

 Thanks
>nvpublic
diff mbox series

Patch

diff --git a/drivers/i2c/busses/i2c-nvidia-gpu.c b/drivers/i2c/busses/i2c-nvidia-gpu.c
index f480105000b8..17a8cefe5c45 100644
--- a/drivers/i2c/busses/i2c-nvidia-gpu.c
+++ b/drivers/i2c/busses/i2c-nvidia-gpu.c
@@ -85,7 +85,7 @@  static int gpu_i2c_check_status(struct gpu_i2c_dev *i2cd)
 				 500, 1000 * USEC_PER_MSEC);
 
 	if (ret) {
-		dev_err(i2cd->dev, "i2c timeout error %x\n", val);
+		dev_info(i2cd->dev, "i2c timeout error %x\n", val);
 		return -ETIMEDOUT;
 	}