| Message ID | 20200920195848.27075-1-krzk@kernel.org |
|---|---|
| State | Accepted |
| Commit | 20199b5c8358b32dab63c4f598e07f6edbf80034 |
| Headers | show |
| Series | [v3,1/4] dt-bindings: gpio: pl061: add gpio-line-names | expand |
On Sun, 20 Sep 2020 21:58:45 +0200, Krzysztof Kozlowski wrote: > Describe common "gpio-line-names" property to fix dtbs_check warnings > like: > > arch/arm64/boot/dts/hisilicon/hi3670-hikey970.dt.yaml: gpio@e8a0b000: > 'gpio-line-names' does not match any of the regexes: 'pinctrl-[0-9]+' > > Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org> > > --- > > Changes since v2: > 1. Common GPIO goes to dt-schema > --- > Documentation/devicetree/bindings/gpio/pl061-gpio.yaml | 3 +++ > 1 file changed, 3 insertions(+) > Reviewed-by: Rob Herring <robh@kernel.org>
On Sun, 20 Sep 2020 21:58:46 +0200, Krzysztof Kozlowski wrote: > Several DTSes with ARMv6 and ARMv7 i.MX SoCs introduce their own > compatibles so add them to fix dtbs_check warnings like: > > arch/arm/boot/dts/imx35-pdk.dt.yaml: gpio@53fa4000: > compatible: ['fsl,imx35-gpio', 'fsl,imx31-gpio'] is not valid under any of the given schemas > > arch/arm/boot/dts/imx51-babbage.dt.yaml: gpio@73f90000: > compatible: ['fsl,imx51-gpio', 'fsl,imx35-gpio'] is not valid under any of the given schemas > > Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org> > > --- > > Changes since v2: > 1. None, split from previous patchset using common GPIO schema > --- > .../devicetree/bindings/gpio/fsl-imx-gpio.yaml | 12 ++++++++++++ > 1 file changed, 12 insertions(+) > Reviewed-by: Rob Herring <robh@kernel.org>
On Sun, 20 Sep 2020 21:58:48 +0200, Krzysztof Kozlowski wrote: > The i.MX 7ULP DTSes use two compatibles so update the binding to fix > dtbs_check warnings like: > > arch/arm/boot/dts/imx7ulp-com.dt.yaml: gpio@40ae0000: > compatible: ['fsl,imx7ulp-gpio', 'fsl,vf610-gpio'] is too long > > arch/arm/boot/dts/imx7ulp-com.dt.yaml: gpio@40ae0000: > compatible: Additional items are not allowed ('fsl,vf610-gpio' was unexpected) > > Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org> > > --- > > Changes since v2: > 1. None, split from previous patchset using common GPIO schema > > Changes since v1: > 1. New patch > --- > Documentation/devicetree/bindings/gpio/gpio-vf610.yaml | 8 +++++--- > 1 file changed, 5 insertions(+), 3 deletions(-) > Reviewed-by: Rob Herring <robh@kernel.org>
On Sun, Sep 20, 2020 at 9:58 PM Krzysztof Kozlowski <krzk@kernel.org> wrote: > Describe common "gpio-line-names" property to fix dtbs_check warnings > like: > > arch/arm64/boot/dts/hisilicon/hi3670-hikey970.dt.yaml: gpio@e8a0b000: > 'gpio-line-names' does not match any of the regexes: 'pinctrl-[0-9]+' > > Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org> Patch applied. Yours, Linus Walleij
On Sun, Sep 20, 2020 at 9:59 PM Krzysztof Kozlowski <krzk@kernel.org> wrote: > The i.MX 7ULP DTSes use two compatibles so update the binding to fix > dtbs_check warnings like: > > arch/arm/boot/dts/imx7ulp-com.dt.yaml: gpio@40ae0000: > compatible: ['fsl,imx7ulp-gpio', 'fsl,vf610-gpio'] is too long > > arch/arm/boot/dts/imx7ulp-com.dt.yaml: gpio@40ae0000: > compatible: Additional items are not allowed ('fsl,vf610-gpio' was unexpected) > > Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org> This patch doesn't apply to my tree linux-gpio "devel": $ git am --signoff ./v3_20200920_krzk_dt_bindings_gpio_pl061_add_gpio_line_names.mbx Applying: dt-bindings: gpio: gpio-vf610: fix iMX 7ULP compatible matching error: Documentation/devicetree/bindings/gpio/gpio-vf610.yaml: does not exist in index Patch failed at 0001 dt-bindings: gpio: gpio-vf610: fix iMX 7ULP compatible matching Yours, Linus Walleij
On Tue, Sep 29, 2020 at 01:54:44PM +0200, Linus Walleij wrote: > On Sun, Sep 20, 2020 at 9:59 PM Krzysztof Kozlowski <krzk@kernel.org> wrote: > > > The i.MX 7ULP DTSes use two compatibles so update the binding to fix > > dtbs_check warnings like: > > > > arch/arm/boot/dts/imx7ulp-com.dt.yaml: gpio@40ae0000: > > compatible: ['fsl,imx7ulp-gpio', 'fsl,vf610-gpio'] is too long > > > > arch/arm/boot/dts/imx7ulp-com.dt.yaml: gpio@40ae0000: > > compatible: Additional items are not allowed ('fsl,vf610-gpio' was unexpected) > > > > Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org> > > This patch doesn't apply to my tree linux-gpio "devel": > > $ git am --signoff > ./v3_20200920_krzk_dt_bindings_gpio_pl061_add_gpio_line_names.mbx > Applying: dt-bindings: gpio: gpio-vf610: fix iMX 7ULP compatible matching > error: Documentation/devicetree/bindings/gpio/gpio-vf610.yaml: does > not exist in index > Patch failed at 0001 dt-bindings: gpio: gpio-vf610: fix iMX 7ULP > compatible matching It's in my tree, so I've applied it. Rob
On Tue, Sep 29, 2020 at 4:02 PM Rob Herring <robh@kernel.org> wrote: > On Tue, Sep 29, 2020 at 01:54:44PM +0200, Linus Walleij wrote: > > On Sun, Sep 20, 2020 at 9:59 PM Krzysztof Kozlowski <krzk@kernel.org> wrote: > > > > > The i.MX 7ULP DTSes use two compatibles so update the binding to fix > > > dtbs_check warnings like: > > > > > > arch/arm/boot/dts/imx7ulp-com.dt.yaml: gpio@40ae0000: > > > compatible: ['fsl,imx7ulp-gpio', 'fsl,vf610-gpio'] is too long > > > > > > arch/arm/boot/dts/imx7ulp-com.dt.yaml: gpio@40ae0000: > > > compatible: Additional items are not allowed ('fsl,vf610-gpio' was unexpected) > > > > > > Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org> > > > > This patch doesn't apply to my tree linux-gpio "devel": > > > > $ git am --signoff > > ./v3_20200920_krzk_dt_bindings_gpio_pl061_add_gpio_line_names.mbx > > Applying: dt-bindings: gpio: gpio-vf610: fix iMX 7ULP compatible matching > > error: Documentation/devicetree/bindings/gpio/gpio-vf610.yaml: does > > not exist in index > > Patch failed at 0001 dt-bindings: gpio: gpio-vf610: fix iMX 7ULP > > compatible matching > > It's in my tree, so I've applied it. Excellent, thanks Rob. Yours, Linus Walleij
diff --git a/Documentation/devicetree/bindings/gpio/pl061-gpio.yaml b/Documentation/devicetree/bindings/gpio/pl061-gpio.yaml index 313b17229247..bd35cbf7fa09 100644 --- a/Documentation/devicetree/bindings/gpio/pl061-gpio.yaml +++ b/Documentation/devicetree/bindings/gpio/pl061-gpio.yaml @@ -51,7 +51,10 @@ properties: gpio-controller: true + gpio-line-names: true + gpio-ranges: + minItems: 1 maxItems: 8 required:
Describe common "gpio-line-names" property to fix dtbs_check warnings like: arch/arm64/boot/dts/hisilicon/hi3670-hikey970.dt.yaml: gpio@e8a0b000: 'gpio-line-names' does not match any of the regexes: 'pinctrl-[0-9]+' Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org> --- Changes since v2: 1. Common GPIO goes to dt-schema --- Documentation/devicetree/bindings/gpio/pl061-gpio.yaml | 3 +++ 1 file changed, 3 insertions(+)