| Message ID | 2736eaf03a5b8bf3aa4566198a98f3d2073d0070.1597236805.git.mchehab+huawei@kernel.org |
|---|---|
| State | Superseded |
| Headers | show |
| Series | spmi: fix some coding style issues at the spmi core | expand |
Quoting Mauro Carvalho Chehab (2020-08-12 05:53:27) > While preparing to port the HiSilicon 6421v600 SPMI driver, > I noticed some coding style issues at the SPMI core. > > Address them. > > Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org> > --- Reviewed-by: Stephen Boyd <sboyd@kernel.org>
Hello: This patch was applied to qcom/linux.git (refs/heads/for-next): On Wed, 12 Aug 2020 14:53:27 +0200 you wrote: > While preparing to port the HiSilicon 6421v600 SPMI driver, > I noticed some coding style issues at the SPMI core. > > Address them. > > Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org> > > [...] Here is the summary with links: - spmi: fix some coding style issues at the spmi core https://git.kernel.org/qcom/c/0be0a733c9cd You are awesome, thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html
diff --git a/drivers/spmi/spmi.c b/drivers/spmi/spmi.c index fd3ff6079b15..253340e10dab 100644 --- a/drivers/spmi/spmi.c +++ b/drivers/spmi/spmi.c @@ -23,6 +23,7 @@ static DEFINE_IDA(ctrl_ida); static void spmi_dev_release(struct device *dev) { struct spmi_device *sdev = to_spmi_device(dev); + kfree(sdev); } @@ -33,6 +34,7 @@ static const struct device_type spmi_dev_type = { static void spmi_ctrl_release(struct device *dev) { struct spmi_controller *ctrl = to_spmi_controller(dev); + ida_simple_remove(&ctrl_ida, ctrl->nr); kfree(ctrl); } @@ -487,7 +489,7 @@ static void of_spmi_register_devices(struct spmi_controller *ctrl) continue; sdev->dev.of_node = node; - sdev->usid = (u8) reg[0]; + sdev->usid = (u8)reg[0]; err = spmi_device_add(sdev); if (err) { @@ -531,6 +533,7 @@ EXPORT_SYMBOL_GPL(spmi_controller_add); static int spmi_ctrl_remove_device(struct device *dev, void *data) { struct spmi_device *spmidev = to_spmi_device(dev); + if (dev->type == &spmi_dev_type) spmi_device_remove(spmidev); return 0;
While preparing to port the HiSilicon 6421v600 SPMI driver, I noticed some coding style issues at the SPMI core. Address them. Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org> --- drivers/spmi/spmi.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-)