diff mbox series

[05/15] net: pcnet: Replace memset+malloc with calloc

Message ID	20200517162425.76584-5-marek.vasut+renesas@gmail.com
State	Accepted
Commit	0e11d79a533e3c874be1c5975abbc52aaba94d93
Headers	show List-Id: U-Boot discussion <u-boot.lists.denx.de> From: marek.vasut at gmail.com (Marek Vasut) Date: Sun, 17 May 2020 18:24:15 +0200 Subject: [PATCH 05/15] net: pcnet: Replace memset+malloc with calloc In-Reply-To: <20200517162425.76584-1-marek.vasut+renesas@gmail.com> References: <20200517162425.76584-1-marek.vasut+renesas@gmail.com> Message-ID: <20200517162425.76584-5-marek.vasut+renesas@gmail.com>
Series	[01/15] net: pcnet: Drop typedef struct pcnet_priv_t \| expand [01/15] net: pcnet: Drop typedef struct pcnet_priv_t [02/15] net: pcnet: Drop PCNET_HAS_PROM [03/15] net: pcnet: Use PCI_DEVICE() to define PCI device compat list [04/15] net: pcnet: Simplify private data allocation [05/15] net: pcnet: Replace memset+malloc with calloc [06/15] net: pcnet: Move private data allocation to initialize [07/15] net: pcnet: Move initialize function at the end [08/15] net: pcnet: Drop useless forward declarations [09/15] net: pcnet: Wrap devbusfn into private data [10/15] net: pcnet: Pass private data through dev->priv [11/15] net: pcnet: Wrap iobase into private data [12/15] net: pcnet: Wrap name and enetaddr into private data [13/15] net: pcnet: Split common and non-DM functions [14/15] net: pcnet: Add DM support [15/15] net: pcnet: Add Kconfig entries

Commit Message

Marek Vasut May 17, 2020, 4:24 p.m. UTC

This combination of functions can be replaced with calloc(),
make it so.

Signed-off-by: Marek Vasut <marek.vasut+renesas at gmail.com>
Cc: Daniel Schwierzeck <daniel.schwierzeck at gmail.com>
Cc: Joe Hershberger <joe.hershberger at ni.com>
---
 drivers/net/pcnet.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff mbox series

Patch

diff --git a/drivers/net/pcnet.c b/drivers/net/pcnet.c
index 5bbd290eec..f5e14ca60d 100644
--- a/drivers/net/pcnet.c
+++ b/drivers/net/pcnet.c
@@ -181,12 +181,11 @@  int pcnet_initialize(bd_t *bis)
 		/*
 		 * Allocate and pre-fill the device structure.
 		 */
-		dev = (struct eth_device *)malloc(sizeof(*dev));
+		dev = calloc(1, sizeof(*dev));
 		if (!dev) {
 			printf("pcnet: Can not allocate memory\n");
 			break;
 		}
-		memset(dev, 0, sizeof(*dev));
 		dev->priv = (void *)(unsigned long)devbusfn;
 		sprintf(dev->name, "pcnet#%d", dev_nr);