| Message ID | 20200509160329.101737-1-xypron.glpk@gmx.de |
|---|---|
| State | Accepted |
| Commit | bdb15776f6d93a1fe7902346db06a2a9fd43381e |
| Headers | show |
| Series | [1/1] cmd: efidebug: fix -Werror=type-limits warning | expand |
diff --git a/cmd/efidebug.c b/cmd/efidebug.c index d8a76d78a3..85ba9f11f8 100644 --- a/cmd/efidebug.c +++ b/cmd/efidebug.c @@ -965,7 +965,7 @@ static int do_efi_boot_next(cmd_tbl_t *cmdtp, int flag, return CMD_RET_USAGE; bootnext = (u16)simple_strtoul(argv[1], &endp, 16); - if (*endp != '\0' || bootnext > 0xffff) { + if (*endp != '\0') { printf("invalid value: %s\n", argv[1]); r = CMD_RET_FAILURE; goto out;
Compiling with -Wtype-limits yields: cmd/efidebug.c:968:32: error: comparison is always false due to limited range of data type [-Werror=type-limits] 968 | if (*endp != '\0' || bootnext > 0xffff) { | Remove the superfluous check. Fixes: 59df7e7e77e7 ("cmd: add efidebug command") Signed-off-by: Heinrich Schuchardt <xypron.glpk at gmx.de> --- cmd/efidebug.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 2.26.2