diff mbox series

[1/1] tools: mkimage: use /* fallthrough */ as needed

Message ID 20200509151042.67947-1-xypron.glpk@gmx.de
State Superseded
Headers show
Series [1/1] tools: mkimage: use /* fallthrough */ as needed | expand

Commit Message

Heinrich Schuchardt May 9, 2020, 3:10 p.m. UTC
GCC recognizes /* fallthrough */ if -Wimplicit-fallthrough=3 is enabled.
Let's use it consistently.

Signed-off-by: Heinrich Schuchardt <xypron.glpk at gmx.de>
---
 tools/mkimage.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

--
2.26.2

Comments

Tom Rini May 15, 2020, 8:53 p.m. UTC | #1
On Sat, May 09, 2020 at 05:10:41PM +0200, Heinrich Schuchardt wrote:

> GCC recognizes /* fallthrough */ if -Wimplicit-fallthrough=3 is enabled.
> Let's use it consistently.
> 
> Signed-off-by: Heinrich Schuchardt <xypron.glpk at gmx.de>

Applied to u-boot/master, thanks!
diff mbox series

Patch

diff --git a/tools/mkimage.c b/tools/mkimage.c
index 336376f8d0..5689e5d75f 100644
--- a/tools/mkimage.c
+++ b/tools/mkimage.c
@@ -211,7 +211,7 @@  static void process_args(int argc, char **argv)
 		case 'f':
 			datafile = optarg;
 			params.auto_its = !strcmp(datafile, "auto");
-			/* no break */
+			/* fallthrough */
 		case 'F':
 			/*
 			 * The flattened image tree (FIT) format