diff mbox series

[1/1] efi_loader: error handling in efi_set_variable_common().

Message ID 20200505234023.60174-1-xypron.glpk@gmx.de
State Accepted
Commit 3fdff6be40b01423aacf2c02eb3b4ef6d2186caf
Headers show
Series [1/1] efi_loader: error handling in efi_set_variable_common(). | expand

Commit Message

Heinrich Schuchardt May 5, 2020, 11:40 p.m. UTC 
Fix unreachable code. Free memory on error.

Signed-off-by: Heinrich Schuchardt <xypron.glpk at gmx.de>
---
 lib/efi_loader/efi_variable.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

--
2.26.2
diff mbox series

Patch

diff --git a/lib/efi_loader/efi_variable.c b/lib/efi_loader/efi_variable.c
index 58f8fae358..33df52e663 100644
--- a/lib/efi_loader/efi_variable.c
+++ b/lib/efi_loader/efi_variable.c
@@ -981,7 +981,7 @@  static efi_status_t efi_set_variable_common(u16 *variable_name,
 	if (append) {
 		old_data = malloc(old_size);
 		if (!old_data) {
-			return EFI_OUT_OF_RESOURCES;
+			ret = EFI_OUT_OF_RESOURCES;
 			goto err;
 		}
 		ret = EFI_CALL(efi_get_variable(variable_name, vendor,