diff mbox series

[v1,2/4] drivers: mmc: iproc_sdhci: enable broken R1B response quirk

Message ID 20200331053406.23063-3-rayagonda.kokatanur@broadcom.com
State New
Headers show
Series fix memory leak and compilation warning and rearrange code | expand

Commit Message

Rayagonda Kokatanur March 31, 2020, 5:34 a.m. UTC 
From: Bharat Kumar Reddy Gooty <bharat.gooty at broadcom.com>

Enable SDHCI_QUIRK_BROKEN_R1B quirk.

Signed-off-by: Bharat Kumar Reddy Gooty <bharat.gooty at broadcom.com>
Signed-off-by: Rayagonda Kokatanur <rayagonda.kokatanur at broadcom.com>
---
 drivers/mmc/iproc_sdhci.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Jaehoon Chung March 31, 2020, 5:41 a.m. UTC | #1 
On 3/31/20 2:34 PM, Rayagonda Kokatanur wrote:
> From: Bharat Kumar Reddy Gooty <bharat.gooty at broadcom.com>
> 
> Enable SDHCI_QUIRK_BROKEN_R1B quirk.

Is there any problem or special reason to add this quirks?

Best Regards,
Jaehoon Chung

> 
> Signed-off-by: Bharat Kumar Reddy Gooty <bharat.gooty at broadcom.com>
> Signed-off-by: Rayagonda Kokatanur <rayagonda.kokatanur at broadcom.com>
> ---
>  drivers/mmc/iproc_sdhci.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/mmc/iproc_sdhci.c b/drivers/mmc/iproc_sdhci.c
> index 36ecdba5c6..f65a1e543d 100644
> --- a/drivers/mmc/iproc_sdhci.c
> +++ b/drivers/mmc/iproc_sdhci.c
> @@ -188,7 +188,7 @@ static int iproc_sdhci_probe(struct udevice *dev)
>  	host->ioaddr = (void *)devfdt_get_addr(dev);
>  	host->voltages = MMC_VDD_165_195 |
>  			 MMC_VDD_32_33 | MMC_VDD_33_34;
> -	host->quirks = SDHCI_QUIRK_BROKEN_VOLTAGE;
> +	host->quirks = SDHCI_QUIRK_BROKEN_VOLTAGE | SDHCI_QUIRK_BROKEN_R1B;
>  	host->host_caps = MMC_MODE_DDR_52MHz;
>  	host->index = fdtdec_get_uint(gd->fdt_blob, node, "index", 0);
>  	host->ops = &sdhci_platform_ops;
>
Rayagonda Kokatanur March 31, 2020, 7:36 a.m. UTC | #2 
On Tue, Mar 31, 2020 at 11:11 AM Jaehoon Chung <jh80.chung at samsung.com> wrote:
>
> On 3/31/20 2:34 PM, Rayagonda Kokatanur wrote:
> > From: Bharat Kumar Reddy Gooty <bharat.gooty at broadcom.com>
> >
> > Enable SDHCI_QUIRK_BROKEN_R1B quirk.
>
> Is there any problem or special reason to add this quirks?

switch command (CMD6) never completed and it used to timeout hence enabled.

Best Regards
Rayagonda

>
> Best Regards,
> Jaehoon Chung
>
> >
> > Signed-off-by: Bharat Kumar Reddy Gooty <bharat.gooty at broadcom.com>
> > Signed-off-by: Rayagonda Kokatanur <rayagonda.kokatanur at broadcom.com>
> > ---
> >  drivers/mmc/iproc_sdhci.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/mmc/iproc_sdhci.c b/drivers/mmc/iproc_sdhci.c
> > index 36ecdba5c6..f65a1e543d 100644
> > --- a/drivers/mmc/iproc_sdhci.c
> > +++ b/drivers/mmc/iproc_sdhci.c
> > @@ -188,7 +188,7 @@ static int iproc_sdhci_probe(struct udevice *dev)
> >       host->ioaddr = (void *)devfdt_get_addr(dev);
> >       host->voltages = MMC_VDD_165_195 |
> >                        MMC_VDD_32_33 | MMC_VDD_33_34;
> > -     host->quirks = SDHCI_QUIRK_BROKEN_VOLTAGE;
> > +     host->quirks = SDHCI_QUIRK_BROKEN_VOLTAGE | SDHCI_QUIRK_BROKEN_R1B;
> >       host->host_caps = MMC_MODE_DDR_52MHz;
> >       host->index = fdtdec_get_uint(gd->fdt_blob, node, "index", 0);
> >       host->ops = &sdhci_platform_ops;
> >
>
diff mbox series

Patch

diff --git a/drivers/mmc/iproc_sdhci.c b/drivers/mmc/iproc_sdhci.c
index 36ecdba5c6..f65a1e543d 100644
--- a/drivers/mmc/iproc_sdhci.c
+++ b/drivers/mmc/iproc_sdhci.c
@@ -188,7 +188,7 @@  static int iproc_sdhci_probe(struct udevice *dev)
 	host->ioaddr = (void *)devfdt_get_addr(dev);
 	host->voltages = MMC_VDD_165_195 |
 			 MMC_VDD_32_33 | MMC_VDD_33_34;
-	host->quirks = SDHCI_QUIRK_BROKEN_VOLTAGE;
+	host->quirks = SDHCI_QUIRK_BROKEN_VOLTAGE | SDHCI_QUIRK_BROKEN_R1B;
 	host->host_caps = MMC_MODE_DDR_52MHz;
 	host->index = fdtdec_get_uint(gd->fdt_blob, node, "index", 0);
 	host->ops = &sdhci_platform_ops;