diff mbox series

[1/3] Dockerfile: Install riscv32 toolchain from kernel.org

Message ID 1585238694-2714-1-git-send-email-bmeng.cn@gmail.com
State New
Headers show
Series [1/3] Dockerfile: Install riscv32 toolchain from kernel.org | expand

Commit Message

Bin Meng March 26, 2020, 4:04 p.m. UTC
This is required to build GRUB UEFI target for RISC-V 32-bit.

Signed-off-by: Bin Meng <bmeng.cn at gmail.com>
---

 Dockerfile | 1 +
 1 file changed, 1 insertion(+)

Comments

Tom Rini March 26, 2020, 4:14 p.m. UTC | #1
On Thu, Mar 26, 2020 at 09:04:52AM -0700, Bin Meng wrote:

> This is required to build GRUB UEFI target for RISC-V 32-bit.
> 
> Signed-off-by: Bin Meng <bmeng.cn at gmail.com>

Since we can use the 64bit toolchain for 32bit U-Boot, can we not pass
GRUB the right flags to use the same toolchain?  Thanks!
Bin Meng March 27, 2020, 1:57 a.m. UTC | #2
Hi Tom,

On Fri, Mar 27, 2020 at 12:14 AM Tom Rini <trini at konsulko.com> wrote:
>
> On Thu, Mar 26, 2020 at 09:04:52AM -0700, Bin Meng wrote:
>
> > This is required to build GRUB UEFI target for RISC-V 32-bit.
> >
> > Signed-off-by: Bin Meng <bmeng.cn at gmail.com>
>
> Since we can use the 64bit toolchain for 32bit U-Boot, can we not pass
> GRUB the right flags to use the same toolchain?  Thanks!
>

The 32-bit GRUB won't build with the 64-bit toolchain as of the
grub-2.04 branch we are using.

Regards,
Bin
Tom Rini March 27, 2020, 1:59 a.m. UTC | #3
On Fri, Mar 27, 2020 at 09:57:47AM +0800, Bin Meng wrote:
> Hi Tom,
> 
> On Fri, Mar 27, 2020 at 12:14 AM Tom Rini <trini at konsulko.com> wrote:
> >
> > On Thu, Mar 26, 2020 at 09:04:52AM -0700, Bin Meng wrote:
> >
> > > This is required to build GRUB UEFI target for RISC-V 32-bit.
> > >
> > > Signed-off-by: Bin Meng <bmeng.cn at gmail.com>
> >
> > Since we can use the 64bit toolchain for 32bit U-Boot, can we not pass
> > GRUB the right flags to use the same toolchain?  Thanks!
> 
> The 32-bit GRUB won't build with the 64-bit toolchain as of the
> grub-2.04 branch we are using.

Is that something that upstream has fixed or will fix / can be fixed and
we can bump the tag we're using for?
Bin Meng March 27, 2020, 6:05 a.m. UTC | #4
Hi Tom,

On Fri, Mar 27, 2020 at 10:00 AM Tom Rini <trini at konsulko.com> wrote:
>
> On Fri, Mar 27, 2020 at 09:57:47AM +0800, Bin Meng wrote:
> > Hi Tom,
> >
> > On Fri, Mar 27, 2020 at 12:14 AM Tom Rini <trini at konsulko.com> wrote:
> > >
> > > On Thu, Mar 26, 2020 at 09:04:52AM -0700, Bin Meng wrote:
> > >
> > > > This is required to build GRUB UEFI target for RISC-V 32-bit.
> > > >
> > > > Signed-off-by: Bin Meng <bmeng.cn at gmail.com>
> > >
> > > Since we can use the 64bit toolchain for 32bit U-Boot, can we not pass
> > > GRUB the right flags to use the same toolchain?  Thanks!
> >
> > The 32-bit GRUB won't build with the 64-bit toolchain as of the
> > grub-2.04 branch we are using.
>
> Is that something that upstream has fixed or will fix / can be fixed and
> we can bump the tag we're using for?

I tried the latest upstream GRUB, and it still cannot be built using
riscv64 toolchain from kernel.org.

Regards,
Bin
Tom Rini March 27, 2020, 3:25 p.m. UTC | #5
On Fri, Mar 27, 2020 at 02:05:55PM +0800, Bin Meng wrote:
> Hi Tom,
> 
> On Fri, Mar 27, 2020 at 10:00 AM Tom Rini <trini at konsulko.com> wrote:
> >
> > On Fri, Mar 27, 2020 at 09:57:47AM +0800, Bin Meng wrote:
> > > Hi Tom,
> > >
> > > On Fri, Mar 27, 2020 at 12:14 AM Tom Rini <trini at konsulko.com> wrote:
> > > >
> > > > On Thu, Mar 26, 2020 at 09:04:52AM -0700, Bin Meng wrote:
> > > >
> > > > > This is required to build GRUB UEFI target for RISC-V 32-bit.
> > > > >
> > > > > Signed-off-by: Bin Meng <bmeng.cn at gmail.com>
> > > >
> > > > Since we can use the 64bit toolchain for 32bit U-Boot, can we not pass
> > > > GRUB the right flags to use the same toolchain?  Thanks!
> > >
> > > The 32-bit GRUB won't build with the 64-bit toolchain as of the
> > > grub-2.04 branch we are using.
> >
> > Is that something that upstream has fixed or will fix / can be fixed and
> > we can bump the tag we're using for?
> 
> I tried the latest upstream GRUB, and it still cannot be built using
> riscv64 toolchain from kernel.org.

Can that be fixed?  Would that be accepted?  Thanks!
Bin Meng March 27, 2020, 11:55 p.m. UTC | #6
Hi Tom,

On Fri, Mar 27, 2020 at 11:25 PM Tom Rini <trini at konsulko.com> wrote:
>
> On Fri, Mar 27, 2020 at 02:05:55PM +0800, Bin Meng wrote:
> > Hi Tom,
> >
> > On Fri, Mar 27, 2020 at 10:00 AM Tom Rini <trini at konsulko.com> wrote:
> > >
> > > On Fri, Mar 27, 2020 at 09:57:47AM +0800, Bin Meng wrote:
> > > > Hi Tom,
> > > >
> > > > On Fri, Mar 27, 2020 at 12:14 AM Tom Rini <trini at konsulko.com> wrote:
> > > > >
> > > > > On Thu, Mar 26, 2020 at 09:04:52AM -0700, Bin Meng wrote:
> > > > >
> > > > > > This is required to build GRUB UEFI target for RISC-V 32-bit.
> > > > > >
> > > > > > Signed-off-by: Bin Meng <bmeng.cn at gmail.com>
> > > > >
> > > > > Since we can use the 64bit toolchain for 32bit U-Boot, can we not pass
> > > > > GRUB the right flags to use the same toolchain?  Thanks!
> > > >
> > > > The 32-bit GRUB won't build with the 64-bit toolchain as of the
> > > > grub-2.04 branch we are using.
> > >
> > > Is that something that upstream has fixed or will fix / can be fixed and
> > > we can bump the tag we're using for?
> >
> > I tried the latest upstream GRUB, and it still cannot be built using
> > riscv64 toolchain from kernel.org.
>
> Can that be fixed?  Would that be accepted?  Thanks!
>

I reported this issue to the grub mailing list. For now I believe we
should stick to current 2.04 until upstream has a solution for it.

Regards,
Bin
Tom Rini March 31, 2020, 3:15 p.m. UTC | #7
On Sat, Mar 28, 2020 at 07:55:37AM +0800, Bin Meng wrote:
> Hi Tom,
> 
> On Fri, Mar 27, 2020 at 11:25 PM Tom Rini <trini at konsulko.com> wrote:
> >
> > On Fri, Mar 27, 2020 at 02:05:55PM +0800, Bin Meng wrote:
> > > Hi Tom,
> > >
> > > On Fri, Mar 27, 2020 at 10:00 AM Tom Rini <trini at konsulko.com> wrote:
> > > >
> > > > On Fri, Mar 27, 2020 at 09:57:47AM +0800, Bin Meng wrote:
> > > > > Hi Tom,
> > > > >
> > > > > On Fri, Mar 27, 2020 at 12:14 AM Tom Rini <trini at konsulko.com> wrote:
> > > > > >
> > > > > > On Thu, Mar 26, 2020 at 09:04:52AM -0700, Bin Meng wrote:
> > > > > >
> > > > > > > This is required to build GRUB UEFI target for RISC-V 32-bit.
> > > > > > >
> > > > > > > Signed-off-by: Bin Meng <bmeng.cn at gmail.com>
> > > > > >
> > > > > > Since we can use the 64bit toolchain for 32bit U-Boot, can we not pass
> > > > > > GRUB the right flags to use the same toolchain?  Thanks!
> > > > >
> > > > > The 32-bit GRUB won't build with the 64-bit toolchain as of the
> > > > > grub-2.04 branch we are using.
> > > >
> > > > Is that something that upstream has fixed or will fix / can be fixed and
> > > > we can bump the tag we're using for?
> > >
> > > I tried the latest upstream GRUB, and it still cannot be built using
> > > riscv64 toolchain from kernel.org.
> >
> > Can that be fixed?  Would that be accepted?  Thanks!
> >
> 
> I reported this issue to the grub mailing list. For now I believe we
> should stick to current 2.04 until upstream has a solution for it.

Has upstream said anything here?  Thanks!
diff mbox series

Patch

diff --git a/Dockerfile b/Dockerfile
index 32d43f7..dc9d6c9 100644
--- a/Dockerfile
+++ b/Dockerfile
@@ -23,6 +23,7 @@  RUN wget -O - https://mirrors.edge.kernel.org/pub/tools/crosstool/files/bin/x86_
 RUN wget -O - https://mirrors.edge.kernel.org/pub/tools/crosstool/files/bin/x86_64/7.3.0/x86_64-gcc-7.3.0-nolibc_microblaze-linux.tar.xz | tar -C /opt -xJ
 RUN wget -O - https://mirrors.edge.kernel.org/pub/tools/crosstool/files/bin/x86_64/7.3.0/x86_64-gcc-7.3.0-nolibc_nios2-linux.tar.xz | tar -C /opt -xJ
 RUN wget -O - https://mirrors.edge.kernel.org/pub/tools/crosstool/files/bin/x86_64/7.3.0/x86_64-gcc-7.3.0-nolibc_powerpc-linux.tar.xz | tar -C /opt -xJ
+RUN wget -O - https://mirrors.edge.kernel.org/pub/tools/crosstool/files/bin/x86_64/7.3.0/x86_64-gcc-7.3.0-nolibc_riscv32-linux.tar.xz | tar -C /opt -xJ
 RUN wget -O - https://mirrors.edge.kernel.org/pub/tools/crosstool/files/bin/x86_64/7.3.0/x86_64-gcc-7.3.0-nolibc_riscv64-linux.tar.xz | tar -C /opt -xJ
 RUN wget -O - https://mirrors.edge.kernel.org/pub/tools/crosstool/files/bin/x86_64/7.3.0/x86_64-gcc-7.3.0-nolibc_sh2-linux.tar.xz | tar -C /opt -xJ