diff mbox series

[v7,12/22] lib: Always set errno in hcreate_r

Message ID	20200319205420.720815-13-seanga2@gmail.com
State	Superseded
Headers	show List-Id: U-Boot discussion <u-boot.lists.denx.de> From: seanga2 at gmail.com (Sean Anderson) Date: Thu, 19 Mar 2020 16:54:10 -0400 Subject: [PATCH v7 12/22] lib: Always set errno in hcreate_r In-Reply-To: <20200319205420.720815-1-seanga2@gmail.com> References: <20200319205420.720815-1-seanga2@gmail.com> Message-ID: <20200319205420.720815-13-seanga2@gmail.com>
Series	riscv: Add Sipeed Maix support \| expand [v7,00/22] riscv: Add Sipeed Maix support [v7,01/22] clk: Always use the supplied struct clk [v7,02/22] clk: Check that ops of composite clock components exist before calling [v7,03/22] clk: Unconditionally recursively en-/dis-able clocks [v7,04/22] clk: Fix clk_get_by_* handling of index [v7,05/22] clk: Add functions to register CCF clock structs [v7,06/22] clk: Add K210 pll support [v7,07/22] clk: Add a bypass clock for K210 [v7,08/22] clk: Add K210 clock support [v7,09/22] dm: Add support for simple-pm-bus [v7,10/22] dm: Fix error handling for dev_read_addr_ptr [v7,11/22] reset: Add generic reset driver [v7,12/22] lib: Always set errno in hcreate_r [v7,13/22] riscv: Add headers for asm/global_data.h [v7,14/22] riscv: Clear pending interrupts before enabling IPIs [v7,15/22] riscv: Clean up IPI initialization code [v7,16/22] riscv: Add option to support RISC-V privileged spec 1.9 [v7,17/22] riscv: Allow use of reset drivers [v7,18/22] riscv: Try to get cpu frequency from a "clocks" node if it exists [v7,19/22] riscv: Enable cpu clock if it is present [v7,20/22] riscv: Add device tree for K210 and Sipeed Maix BitM [v7,21/22] doc: riscv: Add documentation for Sipeed Maix Bit [v7,22/22] riscv: Add Sipeed Maix support

Commit Message

Sean Anderson March 19, 2020, 8:54 p.m. UTC

This could give a confusing error message if it failed and didn't set
errno.

Signed-off-by: Sean Anderson <seanga2 at gmail.com>
Reviewed-by: Bin Meng <bmeng.cn at gmail.com>
---

Changes in v5:
- New

 lib/hashtable.c | 8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)

diff mbox series

Patch

diff --git a/lib/hashtable.c b/lib/hashtable.c
index 907e8a642f..e9ac7e252e 100644
--- a/lib/hashtable.c
+++ b/lib/hashtable.c
@@ -109,8 +109,10 @@  int hcreate_r(size_t nel, struct hsearch_data *htab)
 	}
 
 	/* There is still another table active. Return with error. */
-	if (htab->table != NULL)
+	if (htab->table != NULL) {
+		__set_errno(EINVAL);
 		return 0;
+	}
 
 	/* Change nel to the first prime number not smaller as nel. */
 	nel |= 1;		/* make odd */
@@ -123,8 +125,10 @@  int hcreate_r(size_t nel, struct hsearch_data *htab)
 	/* allocate memory and zero out */
 	htab->table = (struct env_entry_node *)calloc(htab->size + 1,
 						sizeof(struct env_entry_node));
-	if (htab->table == NULL)
+	if (htab->table == NULL) {
+		__set_errno(ENOMEM);
 		return 0;
+	}
 
 	/* everything went alright */
 	return 1;