diff mbox series

[v6,10/12] actions: Move defconfig options to Kconfig

Message ID 1584555949-13815-11-git-send-email-amittomer25@gmail.com
State Superseded
Headers show
Series Actions S700 SoC support | expand

Commit Message

Amit Tomer March 18, 2020, 6:25 p.m. UTC
This patch moves some of the config options from bubblegum_96_defconfig
to platform specific Kconfig file.

Signed-off-by: Amit Singh Tomar <amittomer25 at gmail.com>
---
Changes since v5:
	* Newly added patch, was not there in earlier versions.	
---
 arch/arm/mach-owl/Kconfig      | 16 ++++++++++++++++
 configs/bubblegum_96_defconfig |  5 -----
 2 files changed, 16 insertions(+), 5 deletions(-)

Comments

Andre Przywara March 19, 2020, 1:51 p.m. UTC | #1
On 18/03/2020 18:25, Amit Singh Tomar wrote:
> This patch moves some of the config options from bubblegum_96_defconfig
> to platform specific Kconfig file.
> 
> Signed-off-by: Amit Singh Tomar <amittomer25 at gmail.com>
> ---
> Changes since v5:
> 	* Newly added patch, was not there in earlier versions.	
> ---
>  arch/arm/mach-owl/Kconfig      | 16 ++++++++++++++++
>  configs/bubblegum_96_defconfig |  5 -----
>  2 files changed, 16 insertions(+), 5 deletions(-)
> 
> diff --git a/arch/arm/mach-owl/Kconfig b/arch/arm/mach-owl/Kconfig
> index 1d59d8f..0bd02e2 100644
> --- a/arch/arm/mach-owl/Kconfig
> +++ b/arch/arm/mach-owl/Kconfig
> @@ -25,4 +25,20 @@ config SYS_SOC
>          default "s900" if MACH_S900
>          default "s700" if MACH_S700
>  
> +config DISTRO_DEFAULTS
> +	default y
> +
> +config NR_DRAM_BANKS
> +	default 1
> +
> +config SYS_RELOC_GD_ENV_ADDR
> +	default y
> +
> +config SYS_PROMPT
> +	string "Shell prompt"

Do you need this line?

Rest looks fine, so with this line removed:

Reviewed-by: Andre Przywara <andre.przywara at arm.com>

Cheers,
Andre


> +	default "U-Boot => "
> +
> +config DISPLAY_BOARDINFO
> +	default n
> +
>  endif
> diff --git a/configs/bubblegum_96_defconfig b/configs/bubblegum_96_defconfig
> index e76e9a2..0883167 100644
> --- a/configs/bubblegum_96_defconfig
> +++ b/configs/bubblegum_96_defconfig
> @@ -1,19 +1,14 @@
>  CONFIG_ARM=y
>  CONFIG_ARCH_OWL=y
>  CONFIG_ENV_SIZE=0x2000
> -CONFIG_NR_DRAM_BANKS=1
>  CONFIG_MACH_S900=y
>  CONFIG_IDENT_STRING="\nBubblegum-96"
> -CONFIG_DISTRO_DEFAULTS=y
>  CONFIG_BOOTDELAY=5
>  CONFIG_USE_BOOTARGS=y
>  CONFIG_BOOTARGS="console=ttyOWL5,115200n8"
>  # CONFIG_DISPLAY_CPUINFO is not set
> -# CONFIG_DISPLAY_BOARDINFO is not set
> -CONFIG_SYS_PROMPT="U-Boot => "
>  CONFIG_CMD_MD5SUM=y
>  CONFIG_CMD_MEMINFO=y
>  CONFIG_CMD_CACHE=y
>  CONFIG_CMD_TIMER=y
>  CONFIG_DEFAULT_DEVICE_TREE="bubblegum_96"
> -CONFIG_SYS_RELOC_GD_ENV_ADDR=y
>
diff mbox series

Patch

diff --git a/arch/arm/mach-owl/Kconfig b/arch/arm/mach-owl/Kconfig
index 1d59d8f..0bd02e2 100644
--- a/arch/arm/mach-owl/Kconfig
+++ b/arch/arm/mach-owl/Kconfig
@@ -25,4 +25,20 @@  config SYS_SOC
         default "s900" if MACH_S900
         default "s700" if MACH_S700
 
+config DISTRO_DEFAULTS
+	default y
+
+config NR_DRAM_BANKS
+	default 1
+
+config SYS_RELOC_GD_ENV_ADDR
+	default y
+
+config SYS_PROMPT
+	string "Shell prompt"
+	default "U-Boot => "
+
+config DISPLAY_BOARDINFO
+	default n
+
 endif
diff --git a/configs/bubblegum_96_defconfig b/configs/bubblegum_96_defconfig
index e76e9a2..0883167 100644
--- a/configs/bubblegum_96_defconfig
+++ b/configs/bubblegum_96_defconfig
@@ -1,19 +1,14 @@ 
 CONFIG_ARM=y
 CONFIG_ARCH_OWL=y
 CONFIG_ENV_SIZE=0x2000
-CONFIG_NR_DRAM_BANKS=1
 CONFIG_MACH_S900=y
 CONFIG_IDENT_STRING="\nBubblegum-96"
-CONFIG_DISTRO_DEFAULTS=y
 CONFIG_BOOTDELAY=5
 CONFIG_USE_BOOTARGS=y
 CONFIG_BOOTARGS="console=ttyOWL5,115200n8"
 # CONFIG_DISPLAY_CPUINFO is not set
-# CONFIG_DISPLAY_BOARDINFO is not set
-CONFIG_SYS_PROMPT="U-Boot => "
 CONFIG_CMD_MD5SUM=y
 CONFIG_CMD_MEMINFO=y
 CONFIG_CMD_CACHE=y
 CONFIG_CMD_TIMER=y
 CONFIG_DEFAULT_DEVICE_TREE="bubblegum_96"
-CONFIG_SYS_RELOC_GD_ENV_ADDR=y