diff mbox series

[RFC,v2] cmd: mp: change the command name from cpu to mp

Message ID 20200314144536.28923-1-pragnesh.patel@sifive.com
State Superseded
Headers show
Series [RFC,v2] cmd: mp: change the command name from cpu to mp | expand

Commit Message

Pragnesh Patel March 14, 2020, 2:45 p.m. UTC
When CONFIG_CMD_CPU and CONFIG_MP both are enabled, U-Boot compilation
gives an error of "multiple definition of `_u_boot_list_2_cmd_2_cpu'"
so cpu command(cmd/cpu.c) and mp command(cmd/mp.c) should have different
command name.

Signed-off-by: Pragnesh Patel <pragnesh.patel at sifive.com>
---
 cmd/mp.c | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

Comments

Pragnesh Patel March 14, 2020, 2:48 p.m. UTC | #1
Please ignore this patch, same patch sent again.

>-----Original Message-----
>From: Pragnesh Patel <pragnesh.patel at sifive.com>
>Sent: 14 March 2020 20:16
>To: u-boot at lists.denx.de
>Cc: atish.patra at wdc.com; palmerdabbelt at google.com;
>bmeng.cn at gmail.com; Paul Walmsley <paul.walmsley at sifive.com>;
>rick at andestech.com; Pragnesh Patel <pragnesh.patel at sifive.com>; Simon
>Glass <sjg at chromium.org>
>Subject: [RFC PATCH v2] cmd: mp: change the command name from cpu to mp
>
>When CONFIG_CMD_CPU and CONFIG_MP both are enabled, U-Boot
>compilation gives an error of "multiple definition of
>`_u_boot_list_2_cmd_2_cpu'"
>so cpu command(cmd/cpu.c) and mp command(cmd/mp.c) should have
>different command name.
>
>Signed-off-by: Pragnesh Patel <pragnesh.patel at sifive.com>
>---
> cmd/mp.c | 12 ++++++------
> 1 file changed, 6 insertions(+), 6 deletions(-)
>
>diff --git a/cmd/mp.c b/cmd/mp.c
>index 4c8f5fc3fa..26995c9976 100644
>--- a/cmd/mp.c
>+++ b/cmd/mp.c
>@@ -68,11 +68,11 @@ cpu_cmd(cmd_tbl_t *cmdtp, int flag, int argc, char *
>const argv[])
>
> #ifdef CONFIG_SYS_LONGHELP
> static char cpu_help_text[] =
>-	    "<num> reset                 - Reset cpu <num>\n"
>-	"cpu status                      - Status of all cpus\n"
>-	"cpu <num> status                - Status of cpu <num>\n"
>-	"cpu <num> disable               - Disable cpu <num>\n"
>-	"cpu <num> release <addr> [args] - Release cpu <num> at <addr> with
>[args]"
>+	"mp <num> reset                 - Reset cpu <num>\n"
>+	"mp status                      - Status of all cpus\n"
>+	"mp <num> status                - Status of cpu <num>\n"
>+	"mp <num> disable               - Disable cpu <num>\n"
>+	"mp <num> release <addr> [args] - Release cpu <num> at <addr> with
>[args]"
> #ifdef CONFIG_PPC
> 	"\n"
> 	"                         [args] : <pir> <r3> <r6>\n" \
>@@ -90,6 +90,6 @@ static char cpu_help_text[] =  #endif
>
> U_BOOT_CMD(
>-	cpu, CONFIG_SYS_MAXARGS, 1, cpu_cmd,
>+	mp, CONFIG_SYS_MAXARGS, 1, cpu_cmd,
> 	"Multiprocessor CPU boot manipulation and release", cpu_help_text
>);
>--
>2.17.1
diff mbox series

Patch

diff --git a/cmd/mp.c b/cmd/mp.c
index 4c8f5fc3fa..26995c9976 100644
--- a/cmd/mp.c
+++ b/cmd/mp.c
@@ -68,11 +68,11 @@  cpu_cmd(cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[])
 
 #ifdef CONFIG_SYS_LONGHELP
 static char cpu_help_text[] =
-	    "<num> reset                 - Reset cpu <num>\n"
-	"cpu status                      - Status of all cpus\n"
-	"cpu <num> status                - Status of cpu <num>\n"
-	"cpu <num> disable               - Disable cpu <num>\n"
-	"cpu <num> release <addr> [args] - Release cpu <num> at <addr> with [args]"
+	"mp <num> reset                 - Reset cpu <num>\n"
+	"mp status                      - Status of all cpus\n"
+	"mp <num> status                - Status of cpu <num>\n"
+	"mp <num> disable               - Disable cpu <num>\n"
+	"mp <num> release <addr> [args] - Release cpu <num> at <addr> with [args]"
 #ifdef CONFIG_PPC
 	"\n"
 	"                         [args] : <pir> <r3> <r6>\n" \
@@ -90,6 +90,6 @@  static char cpu_help_text[] =
 #endif
 
 U_BOOT_CMD(
-	cpu, CONFIG_SYS_MAXARGS, 1, cpu_cmd,
+	mp, CONFIG_SYS_MAXARGS, 1, cpu_cmd,
 	"Multiprocessor CPU boot manipulation and release", cpu_help_text
 );