| Message ID | 20200619011442.6926-1-festevam@gmail.com |
|---|---|
| State | Accepted |
| Commit | 64e2793f70c4688977b5e3fa7b503c7f3c7205ac |
| Headers | show |
| Series | ARM: dts: imx6qdl-sabreauto: Fix AR8031 phy-mode | expand |
> As per kernel commit 0672d22a1924 ("ARM: dts: imx: Fix the AR803X phy-mode) > the correct phy-mode should be "rgmii-id", so fix it accordingly > to fix the Ethernet regression. > This problem has been exposed by commit: > commit 13114f38e2ccea9386726d8b9831dfc310589548 > Author: Vladimir Oltean <vladimir.oltean at nxp.com> > Date: Thu May 7 00:11:51 2020 +0200 > phy: atheros: Explicitly disable RGMII delays > To eliminate any doubts about the out-of-reset value of the PHY, that > the driver previously relied on. > If bisecting shows that this commit breaks your board you probably have > a wrong PHY interface mode. You probably want the > PHY_INTERFACE_MODE_RGMII_RXID or PHY_INTERFACE_MODE_RGMII_ID mode. > Signed-off-by: Vladimir Oltean <vladimir.oltean at nxp.com> > Acked-by: Joe Hershberger <joe.hershberger at ni.com> > Fix the phy-mode accordingly to fix the regression. > Signed-off-by: Fabio Estevam <festevam at gmail.com> Applied to u-boot-imx, master, thanks ! Best regards, Stefano Babic
diff --git a/arch/arm/dts/imx6qdl-sabreauto.dtsi b/arch/arm/dts/imx6qdl-sabreauto.dtsi index a6dc5c42c6..28a7fdb0f1 100644 --- a/arch/arm/dts/imx6qdl-sabreauto.dtsi +++ b/arch/arm/dts/imx6qdl-sabreauto.dtsi @@ -281,7 +281,7 @@ &fec { pinctrl-names = "default"; pinctrl-0 = <&pinctrl_enet>; - phy-mode = "rgmii"; + phy-mode = "rgmii-id"; interrupts-extended = <&gpio1 6 IRQ_TYPE_LEVEL_HIGH>, <&intc 0 119 IRQ_TYPE_LEVEL_HIGH>; fsl,err006687-workaround-present;
As per kernel commit 0672d22a1924 ("ARM: dts: imx: Fix the AR803X phy-mode) the correct phy-mode should be "rgmii-id", so fix it accordingly to fix the Ethernet regression. This problem has been exposed by commit: commit 13114f38e2ccea9386726d8b9831dfc310589548 Author: Vladimir Oltean <vladimir.oltean at nxp.com> Date: Thu May 7 00:11:51 2020 +0200 phy: atheros: Explicitly disable RGMII delays To eliminate any doubts about the out-of-reset value of the PHY, that the driver previously relied on. If bisecting shows that this commit breaks your board you probably have a wrong PHY interface mode. You probably want the PHY_INTERFACE_MODE_RGMII_RXID or PHY_INTERFACE_MODE_RGMII_ID mode. Signed-off-by: Vladimir Oltean <vladimir.oltean at nxp.com> Acked-by: Joe Hershberger <joe.hershberger at ni.com> Fix the phy-mode accordingly to fix the regression. Signed-off-by: Fabio Estevam <festevam at gmail.com> --- arch/arm/dts/imx6qdl-sabreauto.dtsi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)