| Message ID | 20200610172842.3728-1-patrick.delaunay@st.com |
|---|---|
| State | Accepted |
| Commit | 35c2683f46bdea96f1dfce404aee4369a824b68e |
| Headers | show |
| Series | env: Kconfig: cosmetics: update comment for SYS_RELOC_GD_ENV_ADDR | expand |
On Wed, Jun 10, 2020 at 07:28:42PM +0200, Patrick Delaunay wrote: > Update the comment for SYS_RELOC_GD_ENV_ADDR as gd->env_addr is updated > in board_r.c::initr_reloc_global_data() under the compilation flags > CONFIG_SYS_RELOC_GD_ENV_ADDR > > Signed-off-by: Patrick Delaunay <patrick.delaunay at st.com> Pretty sure that's just a typo I introduced, thanks for digging at the code to confirm. Reviewed-by: Tom Rini <trini at konsulko.com>
On Wed, Jun 10, 2020 at 07:28:42PM +0200, Patrick Delaunay wrote: > Update the comment for SYS_RELOC_GD_ENV_ADDR as gd->env_addr is updated > in board_r.c::initr_reloc_global_data() under the compilation flags > CONFIG_SYS_RELOC_GD_ENV_ADDR > > Signed-off-by: Patrick Delaunay <patrick.delaunay at st.com> > Reviewed-by: Tom Rini <trini at konsulko.com> Applied to u-boot/master, thanks!
diff --git a/env/Kconfig b/env/Kconfig index ca7fef682b..38e7fadbb9 100644 --- a/env/Kconfig +++ b/env/Kconfig @@ -562,7 +562,7 @@ config ENV_UBI_VID_OFFSET UBI VID offset for environment. If 0, no custom VID offset is used. config SYS_RELOC_GD_ENV_ADDR - bool "Relocate gd->en_addr" + bool "Relocate gd->env_addr" help Relocate the early env_addr pointer so we know it is not inside the binary. Some systems need this and for the rest, it doesn't hurt.
Update the comment for SYS_RELOC_GD_ENV_ADDR as gd->env_addr is updated in board_r.c::initr_reloc_global_data() under the compilation flags CONFIG_SYS_RELOC_GD_ENV_ADDR Signed-off-by: Patrick Delaunay <patrick.delaunay at st.com> --- The current code in board_r.c is: static int initr_reloc_global_data(void) { .... #ifdef CONFIG_SYS_RELOC_GD_ENV_ADDR /* * Relocate the early env_addr pointer unless we know it is not inside * the binary. Some systems need this and for the rest, it doesn't hurt. */ gd->env_addr += gd->reloc_off; #endif ... env/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)