diff mbox series

[v2,05/10] gpio: dw: Fix warnings about casting int to pointer

Message ID 20200608012651.1525906-6-seanga2@gmail.com
State Superseded
Headers show
Series riscv: Add FPIOA and GPIO support for Kendryte K210 | expand

Commit Message

Sean Anderson June 8, 2020, 1:26 a.m. UTC
Change the type of gpio_dwabp_platdata.base from fdt_addr_t to a void
pointer, since we pass it to readl.

Signed-off-by: Sean Anderson <seanga2 at gmail.com>
Reviewed-by: Bin Meng <bmeng.cn at gmail.com>
---
This patch was previously submitted as part of
https://patchwork.ozlabs.org/project/uboot/list/?series=161576

(no changes since v1)

 drivers/gpio/dwapb_gpio.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Tan, Ley Foon June 9, 2020, 1:20 a.m. UTC | #1
> -----Original Message-----
> From: Sean Anderson <seanga2 at gmail.com>
> Sent: Monday, June 8, 2020 9:27 AM
> To: u-boot at lists.denx.de
> Cc: Tom Rini <trini at konsulko.com>; Bin Meng <bmeng.cn at gmail.com>;
> Rick Chen <rickchen36 at gmail.com>; Simon Glass <sjg at chromium.org>;
> Sean Anderson <seanga2 at gmail.com>; Anatolij Gustschin <agust at denx.de>;
> Tan, Ley Foon <ley.foon.tan at intel.com>; Marek Vasut <marex at denx.de>;
> Simon Goldschmidt <simon.k.r.goldschmidt at gmail.com>
> Subject: [PATCH v2 05/10] gpio: dw: Fix warnings about casting int to pointer
> 
> Change the type of gpio_dwabp_platdata.base from fdt_addr_t to a void
> pointer, since we pass it to readl.
> 
> Signed-off-by: Sean Anderson <seanga2 at gmail.com>
> Reviewed-by: Bin Meng <bmeng.cn at gmail.com>
> ---
> This patch was previously submitted as part of
> https://patchwork.ozlabs.org/project/uboot/list/?series=161576
> 
> (no changes since v1)
> 
>  drivers/gpio/dwapb_gpio.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 

Reviewed-by: Ley Foon Tan <ley.foon.tan at intel.com>
Simon Glass June 17, 2020, 3:11 a.m. UTC | #2
On Sun, 7 Jun 2020 at 19:27, Sean Anderson <seanga2 at gmail.com> wrote:
>
> Change the type of gpio_dwabp_platdata.base from fdt_addr_t to a void
> pointer, since we pass it to readl.
>
> Signed-off-by: Sean Anderson <seanga2 at gmail.com>
> Reviewed-by: Bin Meng <bmeng.cn at gmail.com>
> ---
> This patch was previously submitted as part of
> https://patchwork.ozlabs.org/project/uboot/list/?series=161576
>
> (no changes since v1)
>
>  drivers/gpio/dwapb_gpio.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)

Reviewed-by: Simon Glass <sjg at chromium.org>
diff mbox series

Patch

diff --git a/drivers/gpio/dwapb_gpio.c b/drivers/gpio/dwapb_gpio.c
index e5e3518194..bf324f5239 100644
--- a/drivers/gpio/dwapb_gpio.c
+++ b/drivers/gpio/dwapb_gpio.c
@@ -40,7 +40,7 @@  struct gpio_dwapb_platdata {
 	const char	*name;
 	int		bank;
 	int		pins;
-	fdt_addr_t	base;
+	void __iomem	*base;
 };
 
 static int dwapb_gpio_direction_input(struct udevice *dev, unsigned pin)
@@ -176,7 +176,7 @@  static int gpio_dwapb_bind(struct udevice *dev)
 		if (!plat)
 			return -ENOMEM;
 
-		plat->base = base;
+		plat->base = (void *)base;
 		plat->bank = bank;
 		plat->pins = ofnode_read_u32_default(node, "snps,nr-gpios", 0);