diff mbox series

[1/1] arm: wandboard: move CONFIG_MXC_UART to defconfig

Message ID 20200607234347.2392-1-xypron.glpk@gmx.de
State Accepted
Commit a1f79c2170ba425972d626cc6351bcdef2ca9d08
Headers show
Series [1/1] arm: wandboard: move CONFIG_MXC_UART to defconfig | expand

Commit Message

Heinrich Schuchardt June 7, 2020, 11:43 p.m. UTC
For using a debug UART on the Wandboard CONFIG_MXC_UART=y must be set in
the .config file.

To avoid duplicate definitions move the setting from
include/configs/wandboard.h to configs/wandboard_defconfig.

Document the debug UART settings in the README.

Signed-off-by: Heinrich Schuchardt <xypron.glpk at gmx.de>
---
 board/wandboard/README      | 10 ++++++++++
 configs/wandboard_defconfig |  1 +
 include/configs/wandboard.h |  1 -
 3 files changed, 11 insertions(+), 1 deletion(-)

--
2.20.1

Comments

Fabio Estevam June 8, 2020, 12:33 a.m. UTC | #1
On Sun, Jun 7, 2020 at 8:44 PM Heinrich Schuchardt <xypron.glpk at gmx.de> wrote:
>
> For using a debug UART on the Wandboard CONFIG_MXC_UART=y must be set in
> the .config file.
>
> To avoid duplicate definitions move the setting from
> include/configs/wandboard.h to configs/wandboard_defconfig.
>
> Document the debug UART settings in the README.
>
> Signed-off-by: Heinrich Schuchardt <xypron.glpk at gmx.de>

Reviewed-by: Fabio Estevam <festevam at gmail.com>
Stefano Babic June 23, 2020, 7:51 a.m. UTC | #2
> For using a debug UART on the Wandboard CONFIG_MXC_UART=y must be set in
> the .config file.
> To avoid duplicate definitions move the setting from
> include/configs/wandboard.h to configs/wandboard_defconfig.
> Document the debug UART settings in the README.
> Signed-off-by: Heinrich Schuchardt <xypron.glpk at gmx.de>
> Reviewed-by: Fabio Estevam <festevam at gmail.com>
Applied to u-boot-imx, master, thanks !

Best regards,
Stefano Babic
diff mbox series

Patch

diff --git a/board/wandboard/README b/board/wandboard/README
index f84f205337..2d514a7214 100644
--- a/board/wandboard/README
+++ b/board/wandboard/README
@@ -37,3 +37,13 @@  as the mx6 processor)
 - Connect the serial cable to the host PC

 - Power up the board and U-Boot messages will appear in the serial console.
+
+Debug UART
+----------
+
+The following settings provide a debug UART for the Wandboard:
+
+CONFIG_DEBUG_UART=y
+CONFIG_DEBUG_UART_MXC=y
+CONFIG_DEBUG_UART_BASE=0x02020000
+CONFIG_DEBUG_UART_CLOCK=80000000
diff --git a/configs/wandboard_defconfig b/configs/wandboard_defconfig
index 82e517b90f..2040e2df67 100644
--- a/configs/wandboard_defconfig
+++ b/configs/wandboard_defconfig
@@ -68,6 +68,7 @@  CONFIG_PINCTRL_IMX6=y
 CONFIG_DM_PMIC=y
 CONFIG_DM_PMIC_PFUZE100=y
 CONFIG_DM_SCSI=y
+CONFIG_MXC_UART=y
 CONFIG_DM_THERMAL=y
 CONFIG_USB=y
 CONFIG_DM_USB=y
diff --git a/include/configs/wandboard.h b/include/configs/wandboard.h
index a65d23bbe8..ae064f1eb6 100644
--- a/include/configs/wandboard.h
+++ b/include/configs/wandboard.h
@@ -17,7 +17,6 @@ 
 /* Size of malloc() pool */
 #define CONFIG_SYS_MALLOC_LEN		(10 * SZ_1M)

-#define CONFIG_MXC_UART
 #define CONFIG_MXC_UART_BASE		UART1_BASE

 /* SATA Configs */