diff mbox series

[1/6] arm64: dts: rk3399-puma: fix gpio levels for gmac reset pin

Message ID 20200603145929.364923-2-heiko@sntech.de
State Superseded
Headers show
Series revive Theobroma-Systems puma board | expand

Commit Message

Heiko Stuebner June 3, 2020, 2:59 p.m. UTC 
From: Heiko Stuebner <heiko.stuebner at theobroma-systems.com>

The gmac reset has opposite values for the gpio declaration
and the separate reset-active, bring this in line to make
u-boot also find the ethernet-phy.

This mimics the upstream Linus commit found on
https://lore.kernel.org/r/20200603132836.362519-1-heiko at sntech.de

Signed-off-by: Heiko Stuebner <heiko.stuebner at theobroma-systems.com>
---
 arch/arm/dts/rk3399-puma.dtsi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Philipp Tomsich June 3, 2020, 5:11 p.m. UTC | #1 
> On 03.06.2020, at 16:59, Heiko Stuebner <heiko at sntech.de> wrote:
> 
> From: Heiko Stuebner <heiko.stuebner at theobroma-systems.com>
> 
> The gmac reset has opposite values for the gpio declaration
> and the separate reset-active, bring this in line to make
> u-boot also find the ethernet-phy.
> 
> This mimics the upstream Linus commit found on
> https://lore.kernel.org/r/20200603132836.362519-1-heiko at sntech.de
> 
> Signed-off-by: Heiko Stuebner <heiko.stuebner at theobroma-systems.com>

Reviewed-by: Philipp Tomsich <philipp.tomsich at theobroma-systems.com>
diff mbox series

Patch

diff --git a/arch/arm/dts/rk3399-puma.dtsi b/arch/arm/dts/rk3399-puma.dtsi
index 07694b196f..531520e771 100644
--- a/arch/arm/dts/rk3399-puma.dtsi
+++ b/arch/arm/dts/rk3399-puma.dtsi
@@ -157,7 +157,7 @@ 
 	phy-mode = "rgmii";
 	pinctrl-names = "default";
 	pinctrl-0 = <&rgmii_pins>;
-	snps,reset-gpio = <&gpio3 RK_PC0 GPIO_ACTIVE_HIGH>;
+	snps,reset-gpio = <&gpio3 RK_PC0 GPIO_ACTIVE_LOW>;
 	snps,reset-active-low;
 	snps,reset-delays-us = <0 10000 50000>;
 	tx_delay = <0x10>;