| Message ID | 20200703153646.28533-8-patrick.delaunay@st.com |
|---|---|
| State | Accepted |
| Commit | 93d3bc5f8d7ecbbeaa7b55f5c64528420bf10ad4 |
| Headers | show |
| Series | phy: generic: add error trace to detect PHY issue in uclass | expand |
Hi, Le 03/07/2020 ? 17:36, Patrick Delaunay a ?crit : > As the error message is now displayed by generic phy functions, > the pr_err can be change to pr_debug. > > Signed-off-by: Patrick Delaunay <patrick.delaunay at st.com> > --- > > Changes in v3: > - add update for mach-meson board-gx: new generic_phy API usage > > arch/arm/mach-meson/board-gx.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/arch/arm/mach-meson/board-gx.c b/arch/arm/mach-meson/board-gx.c > index c4cc11f1de..b4fde46fcb 100644 > --- a/arch/arm/mach-meson/board-gx.c > +++ b/arch/arm/mach-meson/board-gx.c > @@ -196,8 +196,8 @@ int board_usb_init(int index, enum usb_init_type init) > for (i = 0; i < 2; i++) { > ret = generic_phy_init(&usb_phys[i]); > if (ret) { > - pr_err("Can't init USB PHY%d for %s\n", > - i, ofnode_get_name(dwc2_node)); > + pr_debug("Can't init USB PHY%d for %s\n", > + i, ofnode_get_name(dwc2_node)); > return ret; > } > } > @@ -205,8 +205,8 @@ int board_usb_init(int index, enum usb_init_type init) > for (i = 0; i < 2; i++) { > ret = generic_phy_power_on(&usb_phys[i]); > if (ret) { > - pr_err("Can't power USB PHY%d for %s\n", > - i, ofnode_get_name(dwc2_node)); > + pr_debug("Can't power USB PHY%d for %s\n", > + i, ofnode_get_name(dwc2_node)); > return ret; > } > } > Acked-by: Neil Armstrong <narmstrong at baylibre.com>
On Fri, Jul 03, 2020 at 05:36:46PM +0200, Patrick Delaunay wrote: > As the error message is now displayed by generic phy functions, > the pr_err can be change to pr_debug. > > Signed-off-by: Patrick Delaunay <patrick.delaunay@st.com> > Acked-by: Neil Armstrong <narmstrong@baylibre.com> Applied to u-boot/next, thanks! -- Tom
diff --git a/arch/arm/mach-meson/board-gx.c b/arch/arm/mach-meson/board-gx.c index c4cc11f1de..b4fde46fcb 100644 --- a/arch/arm/mach-meson/board-gx.c +++ b/arch/arm/mach-meson/board-gx.c @@ -196,8 +196,8 @@ int board_usb_init(int index, enum usb_init_type init) for (i = 0; i < 2; i++) { ret = generic_phy_init(&usb_phys[i]); if (ret) { - pr_err("Can't init USB PHY%d for %s\n", - i, ofnode_get_name(dwc2_node)); + pr_debug("Can't init USB PHY%d for %s\n", + i, ofnode_get_name(dwc2_node)); return ret; } } @@ -205,8 +205,8 @@ int board_usb_init(int index, enum usb_init_type init) for (i = 0; i < 2; i++) { ret = generic_phy_power_on(&usb_phys[i]); if (ret) { - pr_err("Can't power USB PHY%d for %s\n", - i, ofnode_get_name(dwc2_node)); + pr_debug("Can't power USB PHY%d for %s\n", + i, ofnode_get_name(dwc2_node)); return ret; } }
As the error message is now displayed by generic phy functions, the pr_err can be change to pr_debug. Signed-off-by: Patrick Delaunay <patrick.delaunay at st.com> --- Changes in v3: - add update for mach-meson board-gx: new generic_phy API usage arch/arm/mach-meson/board-gx.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)