| Message ID | 20200130091527.6405-1-matthias.bgg@kernel.org |
|---|---|
| State | New |
| Headers | show |
| Series | configs: rpi: Set phy auto negotiation | expand |
On Thu, 30 Jan 2020 10:15:26 +0100 matthias.bgg at kernel.org wrote: Hi, > From: Matthias Brugger <mbrugger at suse.com> > > Lower timeout for PHY auto negotiation as otherwise > we have to wait for far too long. Good observation, but isn't this more properly solved by this? https://lists.denx.de/pipermail/u-boot/2020-January/395151.html Joe, can we please merge this ^^^ patch of mine, if there are no objections? Stefan already reviewed it (thanks for that!) Cheers, Andre > Signed-off-by: Matthias Brugger <mbrugger at suse.com> > > --- > > include/configs/rpi.h | 8 ++++++++ > 1 file changed, 8 insertions(+) > > diff --git a/include/configs/rpi.h b/include/configs/rpi.h > index 83e258a6b9..18b817a001 100644 > --- a/include/configs/rpi.h > +++ b/include/configs/rpi.h > @@ -74,6 +74,14 @@ > #define CONFIG_TFTP_TSIZE > #endif > > +/* > + * RPi4 genet uses the generic phy support, set the > + * timeout for auto-negotiation of the PHY in 50 ms units > + */ > +#ifdef PHYLIB > +#define PHY_ANEG_TIMEOUT 20 > +#endif > + > /* Console configuration */ > #define CONFIG_SYS_CBSIZE 1024 >
On 30/01/2020 11:09, Andre Przywara wrote: > On Thu, 30 Jan 2020 10:15:26 +0100 > matthias.bgg at kernel.org wrote: > > Hi, > >> From: Matthias Brugger <mbrugger at suse.com> >> >> Lower timeout for PHY auto negotiation as otherwise >> we have to wait for far too long. > > Good observation, but isn't this more properly solved by this? > https://lists.denx.de/pipermail/u-boot/2020-January/395151.html > > Joe, can we please merge this ^^^ patch of mine, if there are no objections? > Stefan already reviewed it (thanks for that!) > I was looking into that and my mid-term goal was to get PHY_ANEG_TIMEOUT into Kconfig. I stumbled over that yesterday as well, but didn't do the investigation to see if this was broken by some recent commit. So, yes you are right, that's the correct fix. Regards, Matthias > Cheers, > Andre > >> Signed-off-by: Matthias Brugger <mbrugger at suse.com> >> >> --- >> >> include/configs/rpi.h | 8 ++++++++ >> 1 file changed, 8 insertions(+) >> >> diff --git a/include/configs/rpi.h b/include/configs/rpi.h >> index 83e258a6b9..18b817a001 100644 >> --- a/include/configs/rpi.h >> +++ b/include/configs/rpi.h >> @@ -74,6 +74,14 @@ >> #define CONFIG_TFTP_TSIZE >> #endif >> >> +/* >> + * RPi4 genet uses the generic phy support, set the >> + * timeout for auto-negotiation of the PHY in 50 ms units >> + */ >> +#ifdef PHYLIB >> +#define PHY_ANEG_TIMEOUT 20 >> +#endif >> + >> /* Console configuration */ >> #define CONFIG_SYS_CBSIZE 1024 >> >
diff --git a/include/configs/rpi.h b/include/configs/rpi.h index 83e258a6b9..18b817a001 100644 --- a/include/configs/rpi.h +++ b/include/configs/rpi.h @@ -74,6 +74,14 @@ #define CONFIG_TFTP_TSIZE #endif +/* + * RPi4 genet uses the generic phy support, set the + * timeout for auto-negotiation of the PHY in 50 ms units + */ +#ifdef PHYLIB +#define PHY_ANEG_TIMEOUT 20 +#endif + /* Console configuration */ #define CONFIG_SYS_CBSIZE 1024