| Message ID | 20200129201543.4533-4-offougajoris@gmail.com |
|---|---|
| State | Superseded |
| Headers | show |
| Series | [1/4] warp7: fix pmic probe | expand |
On Wed, Jan 29, 2020 at 5:16 PM Joris Offouga <offougajoris at gmail.com> wrote: > > diff --git a/arch/arm/dts/imx7d-sdb-u-boot.dtsi b/arch/arm/dts/imx7d-sdb-u-boot.dtsi > index 05dd74eee1..b78358fa13 100644 > --- a/arch/arm/dts/imx7d-sdb-u-boot.dtsi > +++ b/arch/arm/dts/imx7d-sdb-u-boot.dtsi > @@ -1,3 +1,7 @@ > &fec2 { > status = "disable"; > }; > + > +&usbotg1 { > + dr_mode = "peripheral"; Why to include this in the U-Boot specific version? I see dr_mode = "peripheral" in the main dts. > +}; > -- > 2.20.1 >
Le 29/01/2020 à 21:25, Fabio Estevam a écrit : > On Wed, Jan 29, 2020 at 5:16 PM Joris Offouga <offougajoris at gmail.com> wrote: >> diff --git a/arch/arm/dts/imx7d-sdb-u-boot.dtsi b/arch/arm/dts/imx7d-sdb-u-boot.dtsi >> index 05dd74eee1..b78358fa13 100644 >> --- a/arch/arm/dts/imx7d-sdb-u-boot.dtsi >> +++ b/arch/arm/dts/imx7d-sdb-u-boot.dtsi >> @@ -1,3 +1,7 @@ >> &fec2 { >> status = "disable"; >> }; >> + >> +&usbotg1 { >> + dr_mode = "peripheral"; > Why to include this in the U-Boot specific version? > > I see dr_mode = "peripheral" in the main dts. This is not present in main dts : https://gitlab.denx.de/u-boot/u-boot/blob/master/arch/arm/dts/imx7d-sdb.dts#L401 I include in u-boot.dtsi because is not present in mainline kernel : https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/tree/arch/arm/boot/dts/imx7d-sdb.dts#n413 Best regards, Joris > >> +}; >> -- >> 2.20.1 >>
Hi Joris, On Wed, Jan 29, 2020 at 5:41 PM Joris Offouga <offougajoris at gmail.com> wrote: > This is not present in main dts : > https://gitlab.denx.de/u-boot/u-boot/blob/master/arch/arm/dts/imx7d-sdb.dts#L401 > > I include in u-boot.dtsi because is not present in mainline kernel : > https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/tree/arch/arm/boot/dts/imx7d-sdb.dts#n413 Sorry, I was looking at the warp7 dts. Should we pass 'dr_mode = "peripheral" in the upstream kenel dts? Thanks
diff --git a/arch/arm/dts/imx7d-sdb-u-boot.dtsi b/arch/arm/dts/imx7d-sdb-u-boot.dtsi index 05dd74eee1..b78358fa13 100644 --- a/arch/arm/dts/imx7d-sdb-u-boot.dtsi +++ b/arch/arm/dts/imx7d-sdb-u-boot.dtsi @@ -1,3 +1,7 @@ &fec2 { status = "disable"; }; + +&usbotg1 { + dr_mode = "peripheral"; +};
Before: => ums 0 mmc 0 UMS: LUN 0, dev 0, hwpart 0, sector 0x0, count 0x1dacc00 usb dr_mode not found CTRL+C - Operation aborted => dfu 0 mmc 0 usb dr_mode not found After : => ums 0 mmc 0 UMS: LUN 0, dev 0, hwpart 0, sector 0x0, count 0x1dacc00 => dfu 0 mmc 0 Signed-off-by: Joris Offouga <offougajoris at gmail.com> --- arch/arm/dts/imx7d-sdb-u-boot.dtsi | 4 ++++ 1 file changed, 4 insertions(+)